Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: make-styles-overrides-win conformance test doesn't respect the wrapper renderOption #31306

Open
2 tasks done
CampbellOwen opened this issue May 8, 2024 · 0 comments
Open
2 tasks done

Comments

@CampbellOwen
Copy link
Contributor

CampbellOwen commented May 8, 2024

Library

React Components / v9 (@fluentui/react-components)

System Info

System:
    OS: macOS 14.4.1
    CPU: (14) arm64 Apple M3 Max
    Memory: 66.67 MB / 36.00 GB
    Shell: 5.9 - /bin/zsh
  Browsers:
    Chrome: 123.0.6312.107
    Edge: 124.0.2478.80
    Safari: 17.4.1

Are you reporting Accessibility issue?

None

Reproduction

https://github.com/CampbellOwen/fluentui/blob/user/owcampbe/TestIssueRepro/packages/react-components/react-button/src/components/Button/Button.test.tsx

I added a Wrapper to Button.test.tsx in react-button that doesn't render the button component and the make-styles-overrides-win still passes.

Bug Description

Actual Behavior

The make-styles-overrides-win conformance test in react-conformance-griffel directly renders the Component given and ignores the renderOptions: { wrapper: _ } option.

Expected Behavior

The call to ReactDOM.render(element, container); should pass the wrapper option if provided. This would allow components that require an external context to be tested.

Logs

No response

Requested priority

Normal

Products/sites affected

No response

Are you willing to submit a PR to fix?

no

Validations

  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • The provided reproduction is a minimal reproducible example of the bug.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants