Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Width still is shown in the Skeletons storybook even though the width prop is deprecated #31223

Closed
2 tasks done
snisonoff-microsoft-unmanaged opened this issue Apr 29, 2024 · 1 comment

Comments

@snisonoff-microsoft-unmanaged

Library

React Components / v9 (@fluentui/react-components)

System Info

PR where width was deprecated: https://github.com/microsoft/fluentui/pull/31111

Are you reporting Accessibility issue?

None

Reproduction

https://react.fluentui.dev/?path=/docs/components-skeleton--default

Bug Description

Actual Behavior

Storybook shows width as though it is a prop we are allowed to use

Expected Behavior

Storybook should not show width, because the prop is deprecated

Logs

No response

Requested priority

Blocking

Products/sites affected

TwoUI

Are you willing to submit a PR to fix?

no

Validations

  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • The provided reproduction is a minimal reproducible example of the bug.
@khmakoto
Copy link
Member

This is actually a problem with all deprecated props in storybook in general, I've opened an uber issue to cover all of these in #31245. I'll close this issue in favor of that one.

@khmakoto khmakoto changed the title [Bug]: Width still is shown in the Skeletons storybook even though the width prop is depecated [Bug]: Width still is shown in the Skeletons storybook even though the width prop is deprecated Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants