Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: SkeletonItem does not have a story in the storybook #31222

Open
2 tasks done
snisonoff-microsoft-unmanaged opened this issue Apr 29, 2024 · 1 comment
Open
2 tasks done

Comments

@snisonoff-microsoft-unmanaged

Library

React Components / v9 (@fluentui/react-components)

System Info

There is no story for SkeletonItem
As a result, we had to dig into the code to learn about SkeletonItemSize

Are you reporting Accessibility issue?

None

Reproduction

https://react.fluentui.dev/?path=/docs/components-skeleton--default

Bug Description

Actual Behavior

There is no story for the Skeleton Item

Expected Behavior

The Skeleton Item should have a story, detailing things such as the SkeletonItemSize

Logs

No response

Requested priority

Blocking

Products/sites affected

TwoUI

Are you willing to submit a PR to fix?

no

Validations

  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • The provided reproduction is a minimal reproducible example of the bug.
@khmakoto
Copy link
Member

khmakoto commented May 4, 2024

I think more than adding a story for this component, we should surface its props in the Skeleton docs, just like it is done with Menu.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants