Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: browser validation for inputs doesn't work in safari and firefox #6915

Closed
thomas-kumo opened this issue Feb 26, 2024 · 1 comment
Closed
Labels
closed:obsolete No longer valid status:triage New Issue - needs triage

Comments

@thomas-kumo
Copy link

馃悰 Bug Report

Browser validation is working in chrome but not in safari or firefox. Whenever you submit with a required field but no value in a form in chrome, you get a message from the browser telling your the field is required like the following:

Capture d鈥檈虂cran, le 2024-02-26 a虁 12 41 56

However, we are not getting the same bahavior in safari and firefox.

馃捇 Repro or Code Sample

https://jsfiddle.net/thomasleclerckumo/s92vtLc3/9/

馃 Expected Behavior

I would expect the same behavior as chrome but in safari and firefox too. A proper validation message appearing.

馃槸 Current Behavior

Currently, these are the inputs that has a problem displaying the browser validation message when they have required as an attribute (this is what i've tested so far, maybe more to check) :

  • Radio
  • Checkbox
  • Select
  • Combobox

Currently, when we try to submit, this is the error we are getting in safari:

Capture d鈥檈虂cran, le 2024-02-26 a虁 12 38 17

An invalid form control with name='select' is not focusable.

This is the result I would expect:

Capture d鈥檈虂cran, le 2024-02-26 a虁 12 48 52

馃拋 Possible Solution

I don't know the exact nature of the problem so it's hard for me to come up with a solution but if I find anything, I'll make sure to update the thread here on this issue.

Maybe in house validation from FAST.

馃敠 Context

If you need more context, I'll be more than happy to disclose them with you.

馃敠 EXTRA QUESTIONS

  • Is there any specific reasons why the radio-group isn't form-associated, is there something planned for this component about this?

馃實 Your Environment

"@microsoft/fast-element": "^1.12.0",
"@microsoft/fast-foundation": "^2.49.2",
"@microsoft/fast-react-wrapper": "^0.3.18",
"@microsoft/fast-web-utilities": "^6.0.0",

  • OS & Device: MacOS
  • Browser : Apple Safari, Mozilla FireFox
  • Version Latest
@thomas-kumo thomas-kumo added the status:triage New Issue - needs triage label Feb 26, 2024
@janechu
Copy link
Collaborator

janechu commented May 29, 2024

Unfortunately @microsoft/fast-foundation is being deprecated, refer to #6955.

@janechu janechu closed this as completed May 29, 2024
@janechu janechu added the closed:obsolete No longer valid label May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed:obsolete No longer valid status:triage New Issue - needs triage
Projects
None yet
Development

No branches or pull requests

2 participants