Approximate time helpers #4013
Open
Approximate time helpers #4013
+479
−309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alan Jowett <[email protected]>
Alan-Jowett
requested review from
dthaler,
poornagmsft,
saxena-anurag,
shankarseal,
dv-msft,
gtrevi,
shpalani,
matthewige,
mtfriesen and
rectified95
as code owners
Signed-off-by: Alan Jowett <[email protected]>
Alan-Jowett
force-pushed
the
issue4009
branch
from
b77fd54
to
80b046f
Compare
Signed-off-by: Alan Jowett <[email protected]>
dthaler
reviewed
Nov 15, 2024
Co-authored-by: Dave Thaler <[email protected]>
dthaler
previously approved these changes
Nov 15, 2024
mikeagun
previously approved these changes
Nov 15, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Signed-off-by: Alan Jowett <[email protected]>
mikeagun
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #4009
Description
This pull request introduces new eBPF helper functions for retrieving time since boot in milliseconds and updates the codebase to use a new timing function,
cxplat_query_time_since_boot_precise. Additionally, it includes updates to related data structures and test cases.New eBPF Helper Functions:
bpf_ktime_get_boot_msandbpf_ktime_get_mshelper functions to retrieve time since boot in milliseconds, including and excluding suspended time, respectively. (include/bpf_helper_defs.h,include/ebpf_structs.h,libs/execution_context/ebpf_core.c,libs/execution_context/ebpf_general_helpers.c) [1] [2] [3] [4]Codebase Updates:
ebpf_query_time_since_boot_preciseandebpf_query_time_since_boot_approximatewithcxplat_query_time_since_boot_preciseandcxplat_query_time_since_boot_approximateacross various files for better performance and consistency. (libs/execution_context/ebpf_core.c,libs/execution_context/ebpf_maps.c,libs/execution_context/ebpf_program.c,libs/runtime/ebpf_platform.c,tests/performance/platform.cpp) [1] [2] [3] [4] [5]Data Structures and Test Cases:
ebpf_utility_helpers_data_tstructure to include new timestamp fields in milliseconds. (tests/sample/sample_test_common.h)tests/libs/common/common_tests.cpp,tests/sample/sample_common_routines.h) [1] [2]Testing
CI/CD
Documentation
Yes, doxygen updated.
Installation
No.