Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent type hints for Sequence in interfaces #4783

Open
ekzhu opened this issue Dec 21, 2024 · 2 comments
Open

Consistent type hints for Sequence in interfaces #4783

ekzhu opened this issue Dec 21, 2024 · 2 comments
Labels
needs-triage proj-agentchat
Milestone
0.4.0

Comments

@ekzhu
Copy link
Collaborator

ekzhu commented Dec 21, 2024

Currently List and Sequences are mixed in agentchat.base types. Make them all Sequence as it is more general.

  • ChatAgent.produced_message_types
  • Response.inner_messages
  • TaskRunner.run
  • TaskRunner.run_stream
@ekzhu ekzhu added this to the 0.4.0 milestone Dec 21, 2024
@kartikx
Copy link
Contributor

kartikx commented Dec 21, 2024

Hi, if this is a good first issue can I pick this up? I would like to contribute to AutoGen.

@ekzhu
Copy link
Collaborator Author

ekzhu commented Dec 22, 2024 •
edited
Loading

Sure. There is a time urgency though if you are comfortable with. Let us know asap if you are blocked or otherwise unable to continue. We would like to get this done in a few days. Please read CONTRIBUTING.md to get familiar with the development process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs-triage proj-agentchat
Projects
None yet
Milestone
0.4.0
Development

No branches or pull requests
2 participants
@ekzhu @kartikx