Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ToolCallResultSummaryMessage message type in AgentChat #4754

Closed
ekzhu opened this issue Dec 18, 2024 · 2 comments · Fixed by #4755
Closed

ToolCallResultSummaryMessage message type in AgentChat #4754

ekzhu opened this issue Dec 18, 2024 · 2 comments · Fixed by #4755
Milestone

Comments

@ekzhu
Copy link
Collaborator

ekzhu commented Dec 18, 2024

Thanks, I understand the intent, the challenge for me is that both tool call results and normal responses are now returned as :class:~autogen_agentchat.messages.TextMessage with no differentiating characteristics, making it difficult to determine the difference between a textmessage from the agent and the additional tool call response (or summary) from the tool without tracking additional state (e.g. did I just receive a toolcallresult prior to this message, if so, then the next TextMessage is the tool response, not from the LLM).

I think It would be better to not mix the types. There is already toolcallresultmessage which was was previously the unambiguous way to identify tool results; now tool results are coming in two forms (toolcallresultmessage and another copy in a different format as textmessage) and it is now requires extra logic to try and determine if the textmessage is the tool results or from the LLM.

Can we create a clear message types for the new messages (e.g. toolcallresultsummarymessage) or some other disambiguating way in the message the determine the type of message?

Originally posted by @jspv in #4602 (comment)

@ekzhu ekzhu added this to the 0.4.0 milestone Dec 18, 2024
@ekzhu
Copy link
Collaborator Author

ekzhu commented Dec 18, 2024

@jspv let me know if you are interested in submitting a PR for this issue. It comes down to adding a new message type, and propagate the handling of this to make sure it is not skipped. You can find places TextMessage and other ChatMessage types are referenced.

@jspv
Copy link
Contributor

jspv commented Dec 18, 2024

done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants