Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add warning for returning None from intervention handler #3621

Closed
ekzhu opened this issue Oct 3, 2024 · 3 comments · Fixed by #4149
Closed

Add warning for returning None from intervention handler #3621

ekzhu opened this issue Oct 3, 2024 · 3 comments · Fixed by #4149
Labels
good first issue Good for newcomers proj-core size-small takes 1-2 days
Milestone
0.4.0

Comments

@ekzhu
Copy link
Collaborator

ekzhu commented Oct 3, 2024

Add warning for returning None from intervention handler
@ekzhu ekzhu added the proj-core label Oct 3, 2024
@ekzhu ekzhu removed the needs-triage label Oct 3, 2024
@jackgerrits jackgerrits added the good first issue Good for newcomers label Oct 14, 2024
@decodingafterlife
Copy link

Hey, is this issue still open? If it's possible I'll love to contribute to it; if you could guide me on the same as this will be my first issue.

@rysweet rysweet added this to the future milestone Oct 22, 2024
@jackgerrits jackgerrits modified the milestones: future, 0.4 Oct 22, 2024
@jackgerrits jackgerrits added size-small takes 1-2 days good first issue Good for newcomers proj-core and removed good first issue Good for newcomers proj-core labels Oct 24, 2024
@jackgerrits
Copy link
Member

Feel free to contribute! You should look at where the intervention handled is called in the single threaded runtime

@SANTHOSH-MAMIDISETTI
Copy link

SANTHOSH-MAMIDISETTI commented Nov 1, 2024 •
edited
Loading

Add warning for returning None from intervention handler

Could you please elaborate more @ekzhu ?

@goyalpramod goyalpramod mentioned this issue Nov 12, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers proj-core size-small takes 1-2 days
Projects
None yet
Milestone
0.4.0
Development

Successfully merging a pull request may close this issue.

task: added warning when none is called in intervention handler goyalpramod/autogen
5 participants
@ekzhu @jackgerrits @rysweet @SANTHOSH-MAMIDISETTI @decodingafterlife