File scoped namespaces #1700
Open
File scoped namespaces #1700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI @AndrewKeepCoding |
|
I did. 🙂 |
AndrewKeepCoding
force-pushed
the
file-scoped-namespaces
branch
from
048d735 to
5f4ff16
Compare
Jay-o-Way
reviewed
Dec 14, 2024
| @@ -90,6 +90,9 @@ csharp_style_pattern_matching_over_is_with_cast_check = true:suggestion | |||
| # IDE0016: Null check can be simplified | |||
| csharp_style_throw_expression = true:suggestion | |||
|
|
|||
| # IDE0161: Convert to file-scoped namespace | |||
| csharp_style_namespace_declarations = file_scoped:warning | |||
There was a problem hiding this comment.
Not sure if this needs to be a warning? I don't see any danger in one or the other form.
There was a problem hiding this comment.
I'm following the way taken by CommunityToolkit Gallery and AI Dev Gallery. It's better this way to keep consistency.
|
Are you planning to add a .git-blame-ignore-revs file for this PR? |
AndrewKeepCoding
force-pushed
the
file-scoped-namespaces
branch
from
5b1c533 to
3b20189
Compare
|
@Marv51 You are right. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR will switch C# files from block-scoped namespaces to file-scoped namespaces.
Closes #1689.
Motivation and Context
Improves readability.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes