Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove AutoLoad attr from packages that don't override the Initialize(Async) method #54

Open
madskristensen opened this issue Apr 30, 2018 · 2 comments

Comments

@madskristensen
Copy link
Contributor

madskristensen commented Apr 30, 2018

This is for when the only purpose of the package is to register a service, code expansions or other things that don't require autoload

@AArnott
Copy link
Member

AArnott commented Jul 3, 2018

For prioritization purposes, @madskristensen can you tell me how many times you noticed a Package that would qualify for this diagnostic?

@madskristensen
Copy link
Contributor Author

I don't have data on that, but my assumption is that it is every single package that provides a services and references Shell.14.0 or newer. So definitely a subset of extensions and primarily internal ones I'm guessing. I would mark this a P2 since the impact or converting to async services should be high

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants