Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refundableQuantity Property Missing in SDK for NCE #85

Open
jhughes17 opened this issue Feb 11, 2022 · 7 comments
Open

refundableQuantity Property Missing in SDK for NCE #85

jhughes17 opened this issue Feb 11, 2022 · 7 comments

Comments

@jhughes17
Copy link

With the new rules around subscription reduction in the New Commerce Experience (NCE) we need to view the "refundableQuantity" property to ensure we can reduce a subscription count within 72 hours of it being added. This property is available through the REST API (https://docs.microsoft.com/en-us/partner-center/develop/get-a-subscription-by-id#response-example-for-a-new-commerce-subscription) however I do not see it available in the SDK. Are there plans to get this added so we don't have to create a manual workaround?

thank you

@shogek
Copy link

shogek commented Mar 3, 2022

+1 - this is needed.

@davidjrh
Copy link

davidjrh commented Apr 10, 2022

I'm seeing the property on 3.0.1 package, but not being populated, seems there is an issue while deserializing the object. Anyone else can confirm? Is the nuget package source code available on any public repo?

In fact, the class properties are different from the properties being provided by the Partner Center API, so that's probably the cause of the issue.

image

image

image

IMPORTANT: the Partner Center API is providing this info when calling the "subscription" endpoint, but not on the "subscriptions" endpoint. When obtaining the list of subscriptions, this data is missing.

@davidjrh
Copy link

BTW, the "License info" link on the NuGet gallery is broken (see https://www.nuget.org/packages/Microsoft.Store.PartnerCenter). Is targeting https://partnercenter.microsoft.com/en-us/partner/EULA_Partner_Center_SDK that ends in a 404

@jhughes17
Copy link
Author

hey David! MS Support has confirmed for me that the engineering team is aware and the fix will be published in the next update of the SDK. TrackingID#2204120040022779 for my support case, thank you for your input on this I provided it to them!

@davidjrh
Copy link

Lovely. As a workaround, I'm using the API directly for that specific call and deserializing the result with my own class. Hopefully everything is fixed on the next release.

It's a pain that the nuget package source code is not available on GitHub, mainly if it is just a "wrapper" of a public and well documented API.

@anumuru
Copy link

anumuru commented Aug 1, 2022

This issue is fixed in latest SDK version 3.1.1

@Jordan-Parisee
Copy link

Hello! There seems to still be an issue with this unfortunately. When trying to get the refundable quantity in a bulk get for all subscriptions under a customer, the property always comes back as null. However, when we attempt to get a single subscription by their ID, the property is actually populated. The screenshot below shows the same subscription retrieved from both a bulk and a single call.

image

If someone could please resolve the issue where the property is not populated for bulk calls that would be great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants