Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Solver System to be more extendible and user friendly #10759

Closed
RogPodge opened this issue Jul 18, 2022 · 3 comments
Closed

Refactor Solver System to be more extendible and user friendly #10759

RogPodge opened this issue Jul 18, 2022 · 3 comments
Labels
Epic Feature Request Feature request from the community IssueMigrated MRTK3 Solvers - General
Milestone
MRTK v3.x future

Comments

@RogPodge
Copy link
Contributor

RogPodge commented Jul 18, 2022 •
edited by IssueSyncBot
Loading

This issue has been migrated a new MRTK repository, and the status of this issue will now be tracked at the following location:

Based on comments left from #10748

Basically, Solvers needlessly inherit from Monobehaviors so that they can exist as components on a gameobject, even though they do not perform any independent actions during update. This results in several design quirks, like relying on inspector ordering and having to register and unregister from a SolverHandler.

This issue tracks re-architecting the system to improve on the current design.
@RogPodge RogPodge self-assigned this Jul 18, 2022
@keveleigh
Copy link
Contributor

Previously discussed in #2798 and #4675 as well.

@SimonDarksideJ
Copy link
Contributor

Ahh, this brings back such memories @keveleigh and for beating me to referencing that age old request :D

@Zee2 Zee2 mentioned this issue Jul 20, 2022
Closed
@Zee2 Zee2 mentioned this issue Oct 5, 2022
Closed
@RogPodge RogPodge added this to the MRTK3 GA milestone Nov 19, 2022
@Zee2 Zee2 mentioned this issue Dec 8, 2022
Closed
@AMollis AMollis added MRTK3 GA Feature Request Feature request from the community and removed MRTK3 GA labels Feb 22, 2023
@AMollis AMollis assigned srinjoym and unassigned RogPodge Mar 2, 2023
@AMollis
Copy link
Member

AMollis commented Mar 10, 2023

Related PR #11323

@IssueSyncBot IssueSyncBot mentioned this issue Aug 21, 2023
Open
@IssueSyncBot IssueSyncBot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Epic Feature Request Feature request from the community IssueMigrated MRTK3 Solvers - General
Projects
None yet
Milestone
MRTK v3.x future
Development

No branches or pull requests
6 participants
@SimonDarksideJ @keveleigh @srinjoym @AMollis @RogPodge @IssueSyncBot