Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restoring past trials from storage fails when experiment has no tunables #884

Open
motus opened this issue Nov 21, 2024 · 0 comments
Open
Assignees
Labels
bug Something isn't working mlos-bench tests Add or fix unit tests

Comments

@motus
Copy link
Member

motus commented Nov 21, 2024

When experiment has no tunables at all, restoring data from the storage crashes with the following exception:

File "/root/.local/lib/python3.12/site-packages/streamlit/runtime/fragment.py", line 246, in wrapped_fragment
    result = non_optional_func(*args, **kwargs)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/root/.local/lib/python3.12/site-packages/dashboard/main.py", line 29, in details_page
    exp_and_df = widgets.experiment_picker(storage, "details_page_exp_picker")
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/root/.local/lib/python3.12/site-packages/dashboard/widgets.py", line 248, in experiment_picker
    df = experiment.results_df
         ^^^^^^^^^^^^^^^^^^^^^
File "/root/.local/lib/python3.12/site-packages/mlos_bench/storage/sql/experiment_data.py", line 212, in results_df
    return common.get_results_df(self._engine, self._schema, self._experiment_id)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/root/.local/lib/python3.12/site-packages/mlos_bench/storage/sql/common.py", line 183, in get_results_df
    ExperimentData.CONFIG_COLUMN_PREFIX + row.param_id,
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~
TypeError: can only concatenate str (not "NoneType") to str

We need to handle this situation gracefully and add unit tests to check for this condition.

@motus motus added bug Something isn't working mlos-bench tests Add or fix unit tests labels Nov 21, 2024
@motus motus self-assigned this Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working mlos-bench tests Add or fix unit tests
Projects
None yet
Development

No branches or pull requests

1 participant