Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to load class instances from json config string, not just a file #881

Open
bpkroth opened this issue Nov 14, 2024 · 0 comments · May be fixed by #887
Open

Add ability to load class instances from json config string, not just a file #881

bpkroth opened this issue Nov 14, 2024 · 0 comments · May be fixed by #887
Assignees

Comments

@bpkroth
Copy link
Contributor

bpkroth commented Nov 14, 2024

This is mostly a nicety for writing interactive documentation in #869

Most user interactions with mlos_bench go through json configs, so that's really what we want to document the most.

I'd like to make those more easily browsable in the Sphinx generated docs, which means putting the json example configs into docstrings, but we want to ensure that those continue to load correctly by using doctest

Right now, ConfigPersistenceService only does load_environment via a file, but it'd be pretty easy to extend it to support a json config string as well.

@bpkroth bpkroth self-assigned this Nov 14, 2024
@bpkroth bpkroth linked a pull request Nov 22, 2024 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant