Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: split optimizer-schema.json into multiple files #867

Open
bpkroth opened this issue Oct 4, 2024 · 2 comments
Open

Refactor: split optimizer-schema.json into multiple files #867

bpkroth opened this issue Oct 4, 2024 · 2 comments
Labels
good first issue Good for newcomers low priority Low-priority issue

Comments

@bpkroth
Copy link
Contributor

bpkroth commented Oct 4, 2024

          Future work, but we should probably split this schema up into smaller files like we do for the other schemas.

Originally posted by @bpkroth in #855 (comment)

@bpkroth bpkroth added good first issue Good for newcomers low priority Low-priority issue labels Oct 4, 2024
@Sarishc
Copy link

Sarishc commented Oct 5, 2024

Hi, I would like to work on this issue. Could you please assign it to me and explain how the file should be refactored?

@bpkroth
Copy link
Contributor Author

bpkroth commented Oct 8, 2024

Sure, have a look at this set of schemas for Service configs:
https://github.com/microsoft/MLOS/tree/main/mlos_bench/mlos_bench/config/schemas/services

At a high level services-schema.json specifies the rough schema that all Services must follow by saying it should be one of several child Services, each of which's own config is specified in its own file.

We want to do the same thing here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers low priority Low-priority issue
Projects
None yet
Development

No branches or pull requests

2 participants