Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mlos_bench: Trial repetition #756

Open
yshady opened this issue Jun 24, 2024 · 6 comments · Fixed by #775
Open

mlos_bench: Trial repetition #756

yshady opened this issue Jun 24, 2024 · 6 comments · Fixed by #775

Comments

@yshady
Copy link

yshady commented Jun 24, 2024

I would like to run each config 30 times but not 30 at same time. For example, a default config should be running 30 times but not concurrently.

Currently trial repeat param for mlos_bench will run the trial repeat number all at the same ts_start

@bpkroth
Copy link
Contributor

bpkroth commented Jun 26, 2024

Chatted about this, there is some confusion over some storage entries, but they aren't running concurrently (yet).

We should

  • add ts_create to the DB to note when a trial was "created" vs when its (scheduled to) start(ed)
  • add support for specifying "(random) splay between" trial repeats in the configs
  • enable the scheduler to only start trials with current or past ts_start

motus added a commit that referenced this issue Jul 10, 2024
…r to skip trials (#775)

Solution: truncate microseconds of the current timestamp when scheduling
new trials to be executed ASAP

Closes #756
@bpkroth bpkroth reopened this Jul 11, 2024
@bpkroth
Copy link
Contributor

bpkroth commented Jul 11, 2024

@motus I don't think all of this is handled yet, so reopening.

DelphianCalamity pushed a commit to DelphianCalamity/MLOS that referenced this issue Jul 12, 2024
…r to skip trials (microsoft#775)

Solution: truncate microseconds of the current timestamp when scheduling
new trials to be executed ASAP

Closes microsoft#756
@yshady
Copy link
Author

yshady commented Jul 25, 2024

@eujing can you see if trial repeat with master is still broken? I observed it acts like a minimum bound and not as a maximum

@eujing
Copy link
Contributor

eujing commented Jul 25, 2024

@yshady trial repeat seems to be working at an exact value when using the main branch. I have been using 1, and getting new configs proposed every time. Maybe this is not an issue anymore in the main branch.

@yshady
Copy link
Author

yshady commented Aug 2, 2024

I was using 5 or more

@bpkroth
Copy link
Contributor

bpkroth commented Aug 8, 2024

Should probably just write a test for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants