Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BREAK IN 2.20.0] Remove support for Batch Grouping configuration #23336

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

[BREAK IN 2.20.0] Remove support for Batch Grouping configuration #23336

wants to merge 3 commits into from

Conversation

MarioJGMsoft
Copy link
Contributor

Description

After discussing the work in task #8124, we concluded that it was best to make Batch Grouping dependent on Batch Compression.

This means that we need to remove the ability for users to configure Batch Grouping.

Acceptance Criteria:
Fluid users can no longer configure Batch Grouping.

Execution Plan:
Remove Batch Grouping configuration from containerRuntime.ts and update it to the IContainerRuntimeOptionsInternal.enableGroupedBatching version.

Breaking Changes

This is a breaking change but IContainerRuntimeOptionsInternal has been created to still be compatible with different versions of FF.

Reviewer Guidance

Please let me know if you think there's anything missing that I should add to this PR or anything related to it

@github-actions github-actions bot added area: runtime Runtime related issues public api change Changes to a public API base: main PRs targeted against main branch labels Dec 16, 2024
@MarioJGMsoft MarioJGMsoft linked an issue Dec 16, 2024 that may be closed by this pull request
Removal of IContainerRuntimeOptions.enableGroupedBatching in v2.20 #23270
Open
@github-actions GitHub Actions
Copy link
Contributor

🔗 No broken links found! ✅

Your attention to detail is admirable.

linkcheck output


> [email protected] ci:check-links /home/runner/work/FluidFramework/FluidFramework/docs
> start-server-and-test "npm run serve -- --no-open" 3000 check-links

1: starting server using command "npm run serve -- --no-open"
and when url "[ 'http://127.0.0.1:3000' ]" is responding with HTTP status code 200
running tests using command "npm run check-links"


> [email protected] serve
> docusaurus serve --no-open

[SUCCESS] Serving "build" directory at: http://localhost:3000/

> [email protected] check-links
> linkcheck http://localhost:3000 --skip-file skipped-urls.txt

Crawling...

Stats:
  170006 links
    1595 destination URLs
    1825 URLs ignored
       0 warnings
       0 errors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area: runtime Runtime related issues base: main PRs targeted against main branch changeset-present public api change Changes to a public API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Removal of IContainerRuntimeOptions.enableGroupedBatching in v2.20
1 participant
@MarioJGMsoft