Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove _createDataStoreWithProps #22993

Open
tyler-cai-microsoft opened this issue Nov 5, 2024 · 0 comments · May be fixed by #22996
Open

Remove _createDataStoreWithProps #22993

tyler-cai-microsoft opened this issue Nov 5, 2024 · 0 comments · May be fixed by #22996
Assignees
@tyler-cai-microsoft
Labels
api deprecation Changes to a deprecated API triage

Comments

@tyler-cai-microsoft
Copy link
Contributor

tyler-cai-microsoft commented Nov 5, 2024 •
edited
Loading

Removed APIs

  • IContainerRuntimeBase._createDataStoreWithProps
  • ContainerRuntime._createDataStoreWithProps

Context

AB#856
These apis have been deprecated for over 1 year. We have been trying to remove this api for over 2 years: #11351

Alternatives

The recommended approach is to now use the PureDataObjectFactory.createInstanceWithDataStore to pass in properties and create your datastore.

Compatibility Concerns

Any usages of _createDatastoreWithProps should be removed

Expected Timeline

Removal target: 2.20.0
@tyler-cai-microsoft tyler-cai-microsoft added the api deprecation Changes to a deprecated API label Nov 5, 2024
@tyler-cai-microsoft tyler-cai-microsoft self-assigned this Nov 5, 2024
@tyler-cai-microsoft tyler-cai-microsoft mentioned this issue Nov 5, 2024
Closed
@tyler-cai-microsoft tyler-cai-microsoft linked a pull request Nov 5, 2024 that will close this issue
Remove _createDataStoreWithProps api #22994
Closed
@tyler-cai-microsoft tyler-cai-microsoft linked a pull request Nov 6, 2024 that will close this issue
Open
@jason-ha jason-ha removed a link to a pull request Dec 11, 2024
Remove _createDataStoreWithProps api #22994
Closed
@jason-ha jason-ha linked a pull request Dec 11, 2024 that will close this issue
Remove _createDataStoreWithProps #22996
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tyler-cai-microsoft tyler-cai-microsoft

Labels
api deprecation Changes to a deprecated API triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove _createDataStoreWithProps microsoft/FluidFramework
1 participant
@tyler-cai-microsoft