Fix for SharedTree op named idAllocation #21867
Conversation
⯅ @fluid-example/bundle-size-tests: +245 Bytes
Baseline commit: 38edc9b |
tylerbutler
requested review from
a team,
pragya91,
markfields,
agarwal-navin,
jatgarg,
tyler-cai-microsoft,
kian-thompson and
rajatch-ff
and removed request for
a team
| @@ -607,8 +607,8 @@ function processOp( | |||
| type: string; | |||
| }; | |||
| const address = envelope.address; | |||
| type = `${type}/${innerContent.type}`; | |||
| switch (innerContent.type) { | |||
| type = `${type}/${innerContent?.type}`; | |||
There was a problem hiding this comment.
Looking this over, all this code only applies to FluidDataStoreOp. I'd pull the other 3 to their own case chunk and have it do nothing or whatever makes sense.
You'll be able to remove several as's (e.g. as IEnvelope on line 600) this way too, because the types express the type of contents
There was a problem hiding this comment.
And revert the addition of ?
Friendly ping, @arafat-java, in case you want to come back to this :) |
|
This PR has been automatically marked as stale because it has had no activity for 60 days. It will be closed if no further activity occurs within 8 days of this comment. Thank you for your contributions to Fluid Framework! |
Description
Fixes #21866
When fetch-tool is used to fetch all the ops it fails to fetch block of type="idAllocation" associated with SharedTree
This op usually comes with sequenceNumber=2 with Brainstorm sample app
More details around error log and reproduction steps can be found in bug/issue #21866