Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DXC doesn't compile with /Zc:preprocessor (the new MSVC C++ conformant preprocessor) #7042

Open
devshgraphicsprogramming opened this issue Dec 19, 2024 · 0 comments
Open

DXC doesn't compile with /Zc:preprocessor (the new MSVC C++ conformant preprocessor) #7042

devshgraphicsprogramming opened this issue Dec 19, 2024 · 0 comments
Labels
bug Bug, regression, crash build Issues related to build and setup
Milestone
Dormant

Comments

@devshgraphicsprogramming
Copy link

Description

DXC doesn't compile with /Zc:preprocessor build flag using MSVC.

This may explain some of our issues when trying to compile DXC with vanilla Clang (without using MSVC runtime) instead of MSVC.

Steps to Reproduce

DXC doesn't compile with /Zc:preprocessor build flag using MSVC.

Actual Behavior

Errors around the use-site of DXASSERT, its probably __VA_ARGS__ not removing the , before itself when the va-args are empty.

Environment

  • DXC version: latest trunk
  • Host Operating System: Windows
@devshgraphicsprogramming devshgraphicsprogramming added bug Bug, regression, crash needs-triage Awaiting triage labels Dec 19, 2024
AnastaZIuk added a commit to Devsh-Graphics-Programming/DirectXShaderCompiler that referenced this issue Dec 19, 2024
@AnastaZIuk
preprocessor tweak - use new Standard Conforming Preprocessor when bu…
042b1b5 
…ilding with MSVC, addresses microsoft#7042
AnastaZIuk added a commit to Devsh-Graphics-Programming/DirectXShaderCompiler that referenced this issue Dec 19, 2024
@AnastaZIuk
preprocessor tweak - use new Standard Conforming Preprocessor when bu…
068610b 
…ilding with MSVC, addresses microsoft#7042
@AnastaZIuk AnastaZIuk mentioned this issue Dec 19, 2024
Open
@llvm-beanz llvm-beanz added this to the Dormant milestone Dec 19, 2024
@llvm-beanz llvm-beanz added build Issues related to build and setup and removed needs-triage Awaiting triage labels Dec 19, 2024
@llvm-beanz llvm-beanz moved this to Triaged in HLSL Triage Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Bug, regression, crash build Issues related to build and setup
Projects
HLSL Triage
Status: Triaged
Milestone
Dormant
Development

No branches or pull requests
2 participants
@devshgraphicsprogramming @llvm-beanz