-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AddressTransformation integer handling does the opposite of what it is supposed to #46
Comments
Thanks for the report! The relevant code is: if( (pso.BaseObject is int) ||
(pso.BaseObject is long) ||
(pso.BaseObject is double) ||
(pso.BaseObject is float) )
{
// This will get what the user actually typed (if it was typed).
var asTyped = LanguagePrimitives.ConvertTo< string >( pso ); And the problem is that the comment is wrong in the case of pipelining: if the value was piped in, I have some ideas of some more tricks we could play. |
For the |
Unfortunately this uses private reflection, and there are still cases that it can't handle. Also fixed a sign extension booboo. Helps with #46, but we can't totally fix it without some changes in PowerShell.
Unfortunately this uses private reflection, and there are still cases that it can't handle. Also fixed a sign extension booboo. Helps with #46, but we can't totally fix it without some changes in PowerShell.
I had figured that the inconsistent handling between addresses with only decimal digits was just an unfortunate cost of PowerShell, until I saw the AddressTransformation... so I poked at it a bit more:
The text was updated successfully, but these errors were encountered: