From 075df9fdefe195ec5ca7946cf90866c102579837 Mon Sep 17 00:00:00 2001 From: Enrico Cimitan Date: Mon, 11 Nov 2024 14:21:25 +0100 Subject: [PATCH 1/9] New settings for addin --- .../PowerBIManagement/js/PowerBIManagement.js | 47 ++++++++++--------- .../src/PowerBIManagement.ControlAddin.al | 27 +++++++++++ .../PowerBIManagement/js/PowerBIManagement.js | 47 ++++++++++--------- 3 files changed, 77 insertions(+), 44 deletions(-) diff --git a/src/System Application/App/ControlAddIns/Resources/PowerBIManagement/js/PowerBIManagement.js b/src/System Application/App/ControlAddIns/Resources/PowerBIManagement/js/PowerBIManagement.js index 06a3e840aa..4771566c62 100644 --- a/src/System Application/App/ControlAddIns/Resources/PowerBIManagement/js/PowerBIManagement.js +++ b/src/System Application/App/ControlAddIns/Resources/PowerBIManagement/js/PowerBIManagement.js @@ -16,9 +16,7 @@ var pbiAuthToken = null; var _showBookmarkSelection = false; var _showFilters = false; var _showPageSelection = false; -var _showZoomBar = false; -var _forceTransparentBackground = false; -var _forceFitToPage = false; +var _showZoomBar = true; var _addBottomPadding = false; var _localeSettings = {}; @@ -147,6 +145,15 @@ function InitializeFrame(fullpage, ratio) { } } +function SetSettings(showBookmarkSelection, showFilters, showPageSelection, showZoomBar, forceTransparentBackground, forceFitToPage, addBottomPadding) { + // OBSOLETE + _showBookmarkSelection = showBookmarkSelection; + _showFilters = showFilters; + _showPageSelection = showPageSelection; + _showZoomBar = showZoomBar; + _addBottomPadding = addBottomPadding; +} + // Exposed Functions function EmbedPowerBIReport(reportLink, reportId, pageName) { @@ -345,14 +352,21 @@ function SetToken(authToken) { pbiAuthToken = authToken; } -function SetSettings(showBookmarkSelection, showFilters, showPageSelection, showZoomBar, forceTransparentBackground, forceFitToPage, addBottomPadding) { - _showBookmarkSelection = showBookmarkSelection; - _showFilters = showFilters; - _showPageSelection = showPageSelection; - _showZoomBar = showZoomBar; - _forceTransparentBackground = forceTransparentBackground; - _forceFitToPage = forceFitToPage; - _addBottomPadding = addBottomPadding; +function SetBookmarksVisible(visible) { + _showBookmarkSelection = visible; +} + +function SetFiltersVisible(visible) { + _showFilters = visible; +} + +function SetPageSelectionVisible(visible) { + _showPageSelection = visible; +} + +function SetStatusBarVisible(visible) { + _showZoomBar = visible; + _addBottomPadding = visible; } // Internal functions @@ -407,17 +421,6 @@ function CompileSettings() { localeSettings: _localeSettings } - if (_forceTransparentBackground) { - settingsObject.background = models.BackgroundType.Transparent; - } - - if (_forceFitToPage) { - settingsObject.layoutType = models.LayoutType.Custom; - settingsObject.customLayout = { - displayOption: models.DisplayOption.FitToPage - } - } - return settingsObject; } diff --git a/src/System Application/App/ControlAddIns/src/PowerBIManagement.ControlAddin.al b/src/System Application/App/ControlAddIns/src/PowerBIManagement.ControlAddin.al index 0aa30926ce..bd3bbceee2 100644 --- a/src/System Application/App/ControlAddIns/src/PowerBIManagement.ControlAddin.al +++ b/src/System Application/App/ControlAddIns/src/PowerBIManagement.ControlAddin.al @@ -130,6 +130,31 @@ controladdin PowerBIManagement /// The locale to use, for example "en-us". procedure SetLocale(NewLocale: Text); + /// + /// Controls whether the bookmark selection pane will be visible in the embed experience. Defaults to false. + /// + /// Whether bookmarks should be visible. + procedure SetBookmarksVisible(Visible: Boolean); + + /// + /// Controls whether the filter pane will be visible in the embed experience. Defaults to false. + /// + /// Whether filters should be visible. + procedure SetFiltersVisible(Visible: Boolean); + + /// + /// Controls whether the page selection bar will be visible in the embed experience. Defaults to false. + /// + /// Whether page selection should be visible. + procedure SetPageSelectionVisible(Visible: Boolean); + + /// + /// Controls whether the status bar (that includes zoom contols) will be visible in the embed experience. Defaults to true. + /// + /// Whether status bar should be visible. + procedure SetStatusBarVisible(Visible: Boolean); + +#if not CLEAN26 /// /// Sets the properties for the embed experience /// @@ -140,7 +165,9 @@ controladdin PowerBIManagement ///Forces a transparent background to the embed. ///Forces the Fit To Page behaviour for the embed. ///Controls whether a padding is needed on the bottom of the page (useful in case the embed is the only element displayed on the page). + [Obsolete('Use SetBookmarksVisible, SetFiltersVisible, SetStatusBarVisible, and SetPageSelectionVisible instead. The other options are no longer supported.', '26.0')] procedure SetSettings(ShowBookmarkSelection: Boolean; ShowFilters: Boolean; ShowPageSelection: Boolean; ShowZoomBar: Boolean; ForceTransparentBackground: Boolean; ForceFitToPage: Boolean; AddBottomPadding: Boolean); +#endif #if not CLEAN25 /// diff --git a/src/System Application/App/Resources/PowerBIManagement/js/PowerBIManagement.js b/src/System Application/App/Resources/PowerBIManagement/js/PowerBIManagement.js index 06a3e840aa..4771566c62 100644 --- a/src/System Application/App/Resources/PowerBIManagement/js/PowerBIManagement.js +++ b/src/System Application/App/Resources/PowerBIManagement/js/PowerBIManagement.js @@ -16,9 +16,7 @@ var pbiAuthToken = null; var _showBookmarkSelection = false; var _showFilters = false; var _showPageSelection = false; -var _showZoomBar = false; -var _forceTransparentBackground = false; -var _forceFitToPage = false; +var _showZoomBar = true; var _addBottomPadding = false; var _localeSettings = {}; @@ -147,6 +145,15 @@ function InitializeFrame(fullpage, ratio) { } } +function SetSettings(showBookmarkSelection, showFilters, showPageSelection, showZoomBar, forceTransparentBackground, forceFitToPage, addBottomPadding) { + // OBSOLETE + _showBookmarkSelection = showBookmarkSelection; + _showFilters = showFilters; + _showPageSelection = showPageSelection; + _showZoomBar = showZoomBar; + _addBottomPadding = addBottomPadding; +} + // Exposed Functions function EmbedPowerBIReport(reportLink, reportId, pageName) { @@ -345,14 +352,21 @@ function SetToken(authToken) { pbiAuthToken = authToken; } -function SetSettings(showBookmarkSelection, showFilters, showPageSelection, showZoomBar, forceTransparentBackground, forceFitToPage, addBottomPadding) { - _showBookmarkSelection = showBookmarkSelection; - _showFilters = showFilters; - _showPageSelection = showPageSelection; - _showZoomBar = showZoomBar; - _forceTransparentBackground = forceTransparentBackground; - _forceFitToPage = forceFitToPage; - _addBottomPadding = addBottomPadding; +function SetBookmarksVisible(visible) { + _showBookmarkSelection = visible; +} + +function SetFiltersVisible(visible) { + _showFilters = visible; +} + +function SetPageSelectionVisible(visible) { + _showPageSelection = visible; +} + +function SetStatusBarVisible(visible) { + _showZoomBar = visible; + _addBottomPadding = visible; } // Internal functions @@ -407,17 +421,6 @@ function CompileSettings() { localeSettings: _localeSettings } - if (_forceTransparentBackground) { - settingsObject.background = models.BackgroundType.Transparent; - } - - if (_forceFitToPage) { - settingsObject.layoutType = models.LayoutType.Custom; - settingsObject.customLayout = { - displayOption: models.DisplayOption.FitToPage - } - } - return settingsObject; } From 29d98816fcc8f4c4ee4f8ab522868273ea305a01 Mon Sep 17 00:00:00 2001 From: Enrico Cimitan Date: Mon, 11 Nov 2024 18:51:36 +0100 Subject: [PATCH 2/9] reintroduce bg --- .../Resources/PowerBIManagement/js/PowerBIManagement.js | 6 ++++++ .../ControlAddIns/src/PowerBIManagement.ControlAddin.al | 8 +++++++- .../Resources/PowerBIManagement/js/PowerBIManagement.js | 6 ++++++ 3 files changed, 19 insertions(+), 1 deletion(-) diff --git a/src/System Application/App/ControlAddIns/Resources/PowerBIManagement/js/PowerBIManagement.js b/src/System Application/App/ControlAddIns/Resources/PowerBIManagement/js/PowerBIManagement.js index 4771566c62..a43fdfa809 100644 --- a/src/System Application/App/ControlAddIns/Resources/PowerBIManagement/js/PowerBIManagement.js +++ b/src/System Application/App/ControlAddIns/Resources/PowerBIManagement/js/PowerBIManagement.js @@ -17,6 +17,7 @@ var _showBookmarkSelection = false; var _showFilters = false; var _showPageSelection = false; var _showZoomBar = true; +var _forceTransparentBackground = false; var _addBottomPadding = false; var _localeSettings = {}; @@ -151,6 +152,7 @@ function SetSettings(showBookmarkSelection, showFilters, showPageSelection, show _showFilters = showFilters; _showPageSelection = showPageSelection; _showZoomBar = showZoomBar; + _forceTransparentBackground = forceTransparentBackground; _addBottomPadding = addBottomPadding; } @@ -364,6 +366,10 @@ function SetPageSelectionVisible(visible) { _showPageSelection = visible; } +function SetTransparentBackground(transparent) { + _forceTransparentBackground = transparent; +} + function SetStatusBarVisible(visible) { _showZoomBar = visible; _addBottomPadding = visible; diff --git a/src/System Application/App/ControlAddIns/src/PowerBIManagement.ControlAddin.al b/src/System Application/App/ControlAddIns/src/PowerBIManagement.ControlAddin.al index bd3bbceee2..71c766abd4 100644 --- a/src/System Application/App/ControlAddIns/src/PowerBIManagement.ControlAddin.al +++ b/src/System Application/App/ControlAddIns/src/PowerBIManagement.ControlAddin.al @@ -151,9 +151,15 @@ controladdin PowerBIManagement /// /// Controls whether the status bar (that includes zoom contols) will be visible in the embed experience. Defaults to true. /// - /// Whether status bar should be visible. + /// Whether the status bar should be visible. procedure SetStatusBarVisible(Visible: Boolean); + /// + /// Controls whether the report background should be set to transparent regardless of the actual color. Defaults to false. + /// + /// Whether the background should be force to transparent. + procedure SetTransparentBackground(Transparent: Boolean); + #if not CLEAN26 /// /// Sets the properties for the embed experience diff --git a/src/System Application/App/Resources/PowerBIManagement/js/PowerBIManagement.js b/src/System Application/App/Resources/PowerBIManagement/js/PowerBIManagement.js index 4771566c62..a43fdfa809 100644 --- a/src/System Application/App/Resources/PowerBIManagement/js/PowerBIManagement.js +++ b/src/System Application/App/Resources/PowerBIManagement/js/PowerBIManagement.js @@ -17,6 +17,7 @@ var _showBookmarkSelection = false; var _showFilters = false; var _showPageSelection = false; var _showZoomBar = true; +var _forceTransparentBackground = false; var _addBottomPadding = false; var _localeSettings = {}; @@ -151,6 +152,7 @@ function SetSettings(showBookmarkSelection, showFilters, showPageSelection, show _showFilters = showFilters; _showPageSelection = showPageSelection; _showZoomBar = showZoomBar; + _forceTransparentBackground = forceTransparentBackground; _addBottomPadding = addBottomPadding; } @@ -364,6 +366,10 @@ function SetPageSelectionVisible(visible) { _showPageSelection = visible; } +function SetTransparentBackground(transparent) { + _forceTransparentBackground = transparent; +} + function SetStatusBarVisible(visible) { _showZoomBar = visible; _addBottomPadding = visible; From 4c828941e67adff41d5a500858696f8d6d716be1 Mon Sep 17 00:00:00 2001 From: Enrico Cimitan Date: Mon, 11 Nov 2024 18:59:57 +0100 Subject: [PATCH 3/9] honor bg setting --- .../Resources/PowerBIManagement/js/PowerBIManagement.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/System Application/App/ControlAddIns/Resources/PowerBIManagement/js/PowerBIManagement.js b/src/System Application/App/ControlAddIns/Resources/PowerBIManagement/js/PowerBIManagement.js index a43fdfa809..af5b58c923 100644 --- a/src/System Application/App/ControlAddIns/Resources/PowerBIManagement/js/PowerBIManagement.js +++ b/src/System Application/App/ControlAddIns/Resources/PowerBIManagement/js/PowerBIManagement.js @@ -427,6 +427,10 @@ function CompileSettings() { localeSettings: _localeSettings } + if (_forceTransparentBackground) { + settingsObject.background = models.BackgroundType.Transparent; + } + return settingsObject; } From 200a00e28a4badbe45134fd9f63ddcc7c7d9db25 Mon Sep 17 00:00:00 2001 From: Enrico Cimitan Date: Mon, 11 Nov 2024 19:10:38 +0100 Subject: [PATCH 4/9] honor bg --- .../Resources/PowerBIManagement/js/PowerBIManagement.js | 2 +- .../App/Resources/PowerBIManagement/js/PowerBIManagement.js | 6 +++++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/src/System Application/App/ControlAddIns/Resources/PowerBIManagement/js/PowerBIManagement.js b/src/System Application/App/ControlAddIns/Resources/PowerBIManagement/js/PowerBIManagement.js index af5b58c923..5d588835ad 100644 --- a/src/System Application/App/ControlAddIns/Resources/PowerBIManagement/js/PowerBIManagement.js +++ b/src/System Application/App/ControlAddIns/Resources/PowerBIManagement/js/PowerBIManagement.js @@ -18,7 +18,7 @@ var _showFilters = false; var _showPageSelection = false; var _showZoomBar = true; var _forceTransparentBackground = false; -var _addBottomPadding = false; +var _addBottomPadding = true; var _localeSettings = {}; function Initialize() { diff --git a/src/System Application/App/Resources/PowerBIManagement/js/PowerBIManagement.js b/src/System Application/App/Resources/PowerBIManagement/js/PowerBIManagement.js index a43fdfa809..5d588835ad 100644 --- a/src/System Application/App/Resources/PowerBIManagement/js/PowerBIManagement.js +++ b/src/System Application/App/Resources/PowerBIManagement/js/PowerBIManagement.js @@ -18,7 +18,7 @@ var _showFilters = false; var _showPageSelection = false; var _showZoomBar = true; var _forceTransparentBackground = false; -var _addBottomPadding = false; +var _addBottomPadding = true; var _localeSettings = {}; function Initialize() { @@ -427,6 +427,10 @@ function CompileSettings() { localeSettings: _localeSettings } + if (_forceTransparentBackground) { + settingsObject.background = models.BackgroundType.Transparent; + } + return settingsObject; } From 29350a1d21f3440df13921c011fadfdbdc9ef470 Mon Sep 17 00:00:00 2001 From: Enrico Cimitan Date: Tue, 12 Nov 2024 13:31:07 +0100 Subject: [PATCH 5/9] detailed error msg --- .../Resources/PowerBIManagement/js/PowerBIManagement.js | 8 ++++++-- .../Resources/PowerBIManagement/js/PowerBIManagement.js | 8 ++++++-- 2 files changed, 12 insertions(+), 4 deletions(-) diff --git a/src/System Application/App/ControlAddIns/Resources/PowerBIManagement/js/PowerBIManagement.js b/src/System Application/App/ControlAddIns/Resources/PowerBIManagement/js/PowerBIManagement.js index 5d588835ad..9ecfaa7efe 100644 --- a/src/System Application/App/ControlAddIns/Resources/PowerBIManagement/js/PowerBIManagement.js +++ b/src/System Application/App/ControlAddIns/Resources/PowerBIManagement/js/PowerBIManagement.js @@ -517,14 +517,18 @@ function LogErrorToConsole(operation, error) { } function GetErrorMessage(error) { - if (error && error.message) { - return error.message; + if (error && error.detail && error.detail.detailedMessage) { + return error.detail.detailedMessage; } if (error && error.detail && error.detail.message) { return error.detail.message; } + if (error && error.message) { + return error.message; + } + return error.toString(); } diff --git a/src/System Application/App/Resources/PowerBIManagement/js/PowerBIManagement.js b/src/System Application/App/Resources/PowerBIManagement/js/PowerBIManagement.js index 5d588835ad..9ecfaa7efe 100644 --- a/src/System Application/App/Resources/PowerBIManagement/js/PowerBIManagement.js +++ b/src/System Application/App/Resources/PowerBIManagement/js/PowerBIManagement.js @@ -517,14 +517,18 @@ function LogErrorToConsole(operation, error) { } function GetErrorMessage(error) { - if (error && error.message) { - return error.message; + if (error && error.detail && error.detail.detailedMessage) { + return error.detail.detailedMessage; } if (error && error.detail && error.detail.message) { return error.detail.message; } + if (error && error.message) { + return error.message; + } + return error.toString(); } From 55368cc99259c817f22bc4ff04df350bf1f32a6a Mon Sep 17 00:00:00 2001 From: Enrico Cimitan Date: Tue, 26 Nov 2024 14:21:33 +0100 Subject: [PATCH 6/9] decouple bar and padding --- .../Resources/PowerBIManagement/js/PowerBIManagement.js | 5 ++++- .../ControlAddIns/src/PowerBIManagement.ControlAddin.al | 8 +++++++- .../Resources/PowerBIManagement/js/PowerBIManagement.js | 5 ++++- 3 files changed, 15 insertions(+), 3 deletions(-) diff --git a/src/System Application/App/ControlAddIns/Resources/PowerBIManagement/js/PowerBIManagement.js b/src/System Application/App/ControlAddIns/Resources/PowerBIManagement/js/PowerBIManagement.js index 9ecfaa7efe..32ff468ab9 100644 --- a/src/System Application/App/ControlAddIns/Resources/PowerBIManagement/js/PowerBIManagement.js +++ b/src/System Application/App/ControlAddIns/Resources/PowerBIManagement/js/PowerBIManagement.js @@ -372,7 +372,10 @@ function SetTransparentBackground(transparent) { function SetStatusBarVisible(visible) { _showZoomBar = visible; - _addBottomPadding = visible; +} + +function AddBottomPadding(addPadding) { + _addBottomPadding = addPadding; } // Internal functions diff --git a/src/System Application/App/ControlAddIns/src/PowerBIManagement.ControlAddin.al b/src/System Application/App/ControlAddIns/src/PowerBIManagement.ControlAddin.al index 71c766abd4..bac11ebfa0 100644 --- a/src/System Application/App/ControlAddIns/src/PowerBIManagement.ControlAddin.al +++ b/src/System Application/App/ControlAddIns/src/PowerBIManagement.ControlAddin.al @@ -160,6 +160,12 @@ controladdin PowerBIManagement /// Whether the background should be force to transparent. procedure SetTransparentBackground(Transparent: Boolean); + /// + /// Controls whether the addin includes a bottom padding that makes it look nicer in some embedded scenarios. Defaults to false. + /// + /// Whether the bottom padding should be added. + procedure AddBottomPadding(AddPadding: Boolean); + #if not CLEAN26 /// /// Sets the properties for the embed experience @@ -171,7 +177,7 @@ controladdin PowerBIManagement ///Forces a transparent background to the embed. ///Forces the Fit To Page behaviour for the embed. ///Controls whether a padding is needed on the bottom of the page (useful in case the embed is the only element displayed on the page). - [Obsolete('Use SetBookmarksVisible, SetFiltersVisible, SetStatusBarVisible, and SetPageSelectionVisible instead. The other options are no longer supported.', '26.0')] + [Obsolete('Use SetBookmarksVisible, SetFiltersVisible, SetStatusBarVisible, AddBottomPadding, SetTransparentBackground, and SetPageSelectionVisible instead. The other options are no longer supported.', '26.0')] procedure SetSettings(ShowBookmarkSelection: Boolean; ShowFilters: Boolean; ShowPageSelection: Boolean; ShowZoomBar: Boolean; ForceTransparentBackground: Boolean; ForceFitToPage: Boolean; AddBottomPadding: Boolean); #endif diff --git a/src/System Application/App/Resources/PowerBIManagement/js/PowerBIManagement.js b/src/System Application/App/Resources/PowerBIManagement/js/PowerBIManagement.js index 9ecfaa7efe..32ff468ab9 100644 --- a/src/System Application/App/Resources/PowerBIManagement/js/PowerBIManagement.js +++ b/src/System Application/App/Resources/PowerBIManagement/js/PowerBIManagement.js @@ -372,7 +372,10 @@ function SetTransparentBackground(transparent) { function SetStatusBarVisible(visible) { _showZoomBar = visible; - _addBottomPadding = visible; +} + +function AddBottomPadding(addPadding) { + _addBottomPadding = addPadding; } // Internal functions From 91cced3825872e2b12b2c55711818d0febe9b326 Mon Sep 17 00:00:00 2001 From: Enrico Cimitan Date: Tue, 26 Nov 2024 15:31:34 +0100 Subject: [PATCH 7/9] default padding to false --- .../Resources/PowerBIManagement/js/PowerBIManagement.js | 2 +- .../App/Resources/PowerBIManagement/js/PowerBIManagement.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/System Application/App/ControlAddIns/Resources/PowerBIManagement/js/PowerBIManagement.js b/src/System Application/App/ControlAddIns/Resources/PowerBIManagement/js/PowerBIManagement.js index 32ff468ab9..666a0c2a20 100644 --- a/src/System Application/App/ControlAddIns/Resources/PowerBIManagement/js/PowerBIManagement.js +++ b/src/System Application/App/ControlAddIns/Resources/PowerBIManagement/js/PowerBIManagement.js @@ -18,7 +18,7 @@ var _showFilters = false; var _showPageSelection = false; var _showZoomBar = true; var _forceTransparentBackground = false; -var _addBottomPadding = true; +var _addBottomPadding = false; var _localeSettings = {}; function Initialize() { diff --git a/src/System Application/App/Resources/PowerBIManagement/js/PowerBIManagement.js b/src/System Application/App/Resources/PowerBIManagement/js/PowerBIManagement.js index 32ff468ab9..666a0c2a20 100644 --- a/src/System Application/App/Resources/PowerBIManagement/js/PowerBIManagement.js +++ b/src/System Application/App/Resources/PowerBIManagement/js/PowerBIManagement.js @@ -18,7 +18,7 @@ var _showFilters = false; var _showPageSelection = false; var _showZoomBar = true; var _forceTransparentBackground = false; -var _addBottomPadding = true; +var _addBottomPadding = false; var _localeSettings = {}; function Initialize() { From d440d0926c0552328261e049dc840265a5b68c00 Mon Sep 17 00:00:00 2001 From: Enrico Cimitan Date: Tue, 26 Nov 2024 15:59:37 +0100 Subject: [PATCH 8/9] Remove status bar option --- .../Resources/PowerBIManagement/js/PowerBIManagement.js | 4 ---- .../App/ControlAddIns/src/PowerBIManagement.ControlAddin.al | 6 ------ .../App/Resources/PowerBIManagement/js/PowerBIManagement.js | 4 ---- 3 files changed, 14 deletions(-) diff --git a/src/System Application/App/ControlAddIns/Resources/PowerBIManagement/js/PowerBIManagement.js b/src/System Application/App/ControlAddIns/Resources/PowerBIManagement/js/PowerBIManagement.js index 666a0c2a20..a065af9aa5 100644 --- a/src/System Application/App/ControlAddIns/Resources/PowerBIManagement/js/PowerBIManagement.js +++ b/src/System Application/App/ControlAddIns/Resources/PowerBIManagement/js/PowerBIManagement.js @@ -370,10 +370,6 @@ function SetTransparentBackground(transparent) { _forceTransparentBackground = transparent; } -function SetStatusBarVisible(visible) { - _showZoomBar = visible; -} - function AddBottomPadding(addPadding) { _addBottomPadding = addPadding; } diff --git a/src/System Application/App/ControlAddIns/src/PowerBIManagement.ControlAddin.al b/src/System Application/App/ControlAddIns/src/PowerBIManagement.ControlAddin.al index bac11ebfa0..7b85d8b997 100644 --- a/src/System Application/App/ControlAddIns/src/PowerBIManagement.ControlAddin.al +++ b/src/System Application/App/ControlAddIns/src/PowerBIManagement.ControlAddin.al @@ -148,12 +148,6 @@ controladdin PowerBIManagement /// Whether page selection should be visible. procedure SetPageSelectionVisible(Visible: Boolean); - /// - /// Controls whether the status bar (that includes zoom contols) will be visible in the embed experience. Defaults to true. - /// - /// Whether the status bar should be visible. - procedure SetStatusBarVisible(Visible: Boolean); - /// /// Controls whether the report background should be set to transparent regardless of the actual color. Defaults to false. /// diff --git a/src/System Application/App/Resources/PowerBIManagement/js/PowerBIManagement.js b/src/System Application/App/Resources/PowerBIManagement/js/PowerBIManagement.js index 666a0c2a20..a065af9aa5 100644 --- a/src/System Application/App/Resources/PowerBIManagement/js/PowerBIManagement.js +++ b/src/System Application/App/Resources/PowerBIManagement/js/PowerBIManagement.js @@ -370,10 +370,6 @@ function SetTransparentBackground(transparent) { _forceTransparentBackground = transparent; } -function SetStatusBarVisible(visible) { - _showZoomBar = visible; -} - function AddBottomPadding(addPadding) { _addBottomPadding = addPadding; } From 7fd84cb0c3b7dce9826cd78118c1ec93acfecd0f Mon Sep 17 00:00:00 2001 From: Enrico Cimitan Date: Tue, 26 Nov 2024 16:10:26 +0100 Subject: [PATCH 9/9] fix obsoletion message --- .../App/ControlAddIns/src/PowerBIManagement.ControlAddin.al | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/System Application/App/ControlAddIns/src/PowerBIManagement.ControlAddin.al b/src/System Application/App/ControlAddIns/src/PowerBIManagement.ControlAddin.al index 7b85d8b997..47da51ef28 100644 --- a/src/System Application/App/ControlAddIns/src/PowerBIManagement.ControlAddin.al +++ b/src/System Application/App/ControlAddIns/src/PowerBIManagement.ControlAddin.al @@ -159,7 +159,7 @@ controladdin PowerBIManagement /// /// Whether the bottom padding should be added. procedure AddBottomPadding(AddPadding: Boolean); - + #if not CLEAN26 /// /// Sets the properties for the embed experience @@ -171,7 +171,7 @@ controladdin PowerBIManagement ///Forces a transparent background to the embed. ///Forces the Fit To Page behaviour for the embed. ///Controls whether a padding is needed on the bottom of the page (useful in case the embed is the only element displayed on the page). - [Obsolete('Use SetBookmarksVisible, SetFiltersVisible, SetStatusBarVisible, AddBottomPadding, SetTransparentBackground, and SetPageSelectionVisible instead. The other options are no longer supported.', '26.0')] + [Obsolete('Use SetBookmarksVisible, SetFiltersVisible, AddBottomPadding, SetTransparentBackground, and SetPageSelectionVisible instead. The other options are no longer supported.', '26.0')] procedure SetSettings(ShowBookmarkSelection: Boolean; ShowFilters: Boolean; ShowPageSelection: Boolean; ShowZoomBar: Boolean; ForceTransparentBackground: Boolean; ForceFitToPage: Boolean; AddBottomPadding: Boolean); #endif