Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration tests to AMQPMessageConsumptionTaskITest class #1130

Merged
merged 2 commits into from Apr 8, 2024

Conversation

mcruzdev
Copy link
Contributor

@mcruzdev mcruzdev commented Apr 6, 2024

Description

  • Add integration test to AMQPMessageConsumptionTaskITest
  • Add testcontainers to microcks-async-minion

Related issue(s)

Fixes #1128

Copy link

github-actions bot commented Apr 6, 2024

👋 @mcruzdev

Welcome to the Microcks community! 💖

Thanks and congrats 🎉 for opening your first pull request here! Be sure to follow the pull request template or please update it accordingly.

Hope you have a great time there!

@mcruzdev
Copy link
Contributor Author

mcruzdev commented Apr 6, 2024

I will add more tests to another destination types (direct, topic, headers, fanout) later, on this pull request.

@mcruzdev
Copy link
Contributor Author

mcruzdev commented Apr 7, 2024

Hi @lbroudoux, I think you can review it now!

Was necessary to send some message to the exchange asynchronously because it:

When a published message cannot be routed to any queue (e.g. because there are no bindings defined for the target exchange), and the publisher set the mandatory message property to false (this is the default), the message is discarded or republished to an alternate exchange, if any.

In your experience, do you have another way to solve this?

@lbroudoux lbroudoux changed the base branch from master to 1.9.x April 8, 2024 08:12
@lbroudoux
Copy link
Member

Hello! Thank you very much for the PR! Looks good and it sounds like you onboarded very quickly!

In your experience, do you have another way to solve this?

Unfortunately no... I don't see other ways to overcome that. I've done the same kind of things in the tests for the Microcks Testcontainers modules...

@lbroudoux lbroudoux added this to the 1.9.1 milestone Apr 8, 2024
@lbroudoux lbroudoux merged commit 4955fd1 into microcks:1.9.x Apr 8, 2024
4 of 7 checks passed
Copy link

github-actions bot commented Apr 8, 2024

🎉 @mcruzdev

You are now a Microcks community contributor! 💖

Thanks and congrats 🚀 on merging your first pull request! We are delighted and very proud of you! 👏

📢 If you're using Microcks in your organization, please add your company name to this list. 🙏 It really helps the project to gain momentum and credibility. It's a small contribution back to the project with a big impact.

If you need to know why and how to add yourself to the list, please read the blog post "Join the Microcks Adopters list and Empower the vibrant open source Community 🙌"

Kudos and please keep going, we need you 🙌

@lbroudoux
Copy link
Member

Thank you very much @mcruzdev!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more tests for 1.9.1
2 participants