Add more tests for 1.9.1

[mcruzdev]

Reason/Context

This proposal aims to increase the quality and maintainability of the project, adding more unit and integration tests.

Description

Add tests to:

• AMQPMessageConsumptionTask
• UploadArtifactController

Implementation ideas

No response

[github-actions]

👋 @mcruzdev

Welcome to the Microcks community! 💖

Thanks and congrats 🎉 for opening your first issue here! Be sure to follow the issue template or please update it accordingly.

📢 If you're using Microcks in your organization, please add your company name to this list. 🙏 It really helps the project to gain momentum and credibility. It's a small contribution back to the project with a big impact.

If you need to know why and how to add yourself to the list, please read the blog post "Join the Microcks Adopters list and Empower the vibrant open source Community 🙌"

Hope you have a great time there!

[lbroudoux]

Thanks for the suggestion! Do you plan to have an attached PR on this one or have you faced a particular situation on JobService that would require some specific cautions?

[mcruzdev]

I would like to work with baby steps, one class per time, because normally I contribute in my free times hehe, what do you think?

[mcruzdev]

It is a good way to know in deep dive the project too, I want to grow the coverage of the project testing some scenario, this is my idea.

[lbroudoux]

This is great! Have you been able to check the SonarCloud instance? There you'll get the map of risks vs coverage of the different components.

[mcruzdev]

Seeing the SonarQube map, I started with AMQPMessageConsumptionTaskITest class.

[lbroudoux]

Hey @mcruzdev! Thanks again for the PR regarding AMQPMessageConsumptionTask!
Do you think you'll push some other ones and we will keep this issue open, or is it better to close this one, and you may reopen some other PR in the future? WDYT?

[mcruzdev]

Hi @lbroudoux do not close, I want to add more tests :)

[lbroudoux]

Awesome!

[lbroudoux]

Just updated the issue name to scope it to 1.9.1 release (for now 😉)

[lbroudoux]

Hi @mcruzdev !
I'm gonna close this issue as 1.9.1 is now ready for release. New tests are more than welcome but it will be on another branch to prepare the next 1.10 iteration.
See you around!