Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions test_pages_build.yaml workflow fails on cross-fork PRs #2199

Open
eecavanna opened this issue Oct 8, 2024 · 2 comments
Open
Assignees
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@eecavanna
Copy link
Collaborator

Recent runs (as shown on https://github.com/microbiomedata/nmdc-schema/actions/workflows/test_pages_build.yaml):

image

Error info:

image

HTTP 403 stands for "Forbidden":

The HTTP 403 Forbidden client error response status code indicates that the server understood the request but refused to process it. This status is similar to 401, except that for 403 Forbidden responses, authenticating or re-authenticating makes no difference. The request failure is tied to application logic, such as insufficient permissions to a resource or action.

@eecavanna eecavanna added bug Something isn't working documentation Improvements or additions to documentation labels Oct 8, 2024
@eecavanna
Copy link
Collaborator Author

In the screenshot above, all the failing runs involve a branch from berkeley-schema-fy24 (i.e. the fork repo) being merged into the upstream repo. I wonder whether the GHA workflow does not handle that.

@eecavanna
Copy link
Collaborator Author

eecavanna commented Oct 8, 2024

Related: rossjrw/pr-preview-action#6 (credits: I think it was our teammate, PK, that found that related issue)

After having skimmed that issue, I think this is a "known limitation" of the pr-preview-action.

I propose we accept it as a limitation for inter-fork PRs and move on; rather than invest time in fixing it.

With that in mind, I propose this as the task for this ticket:

  • Document this limitation and advertise it to contributors so they are not surprised and distracted when this particular GHA workflow fails in inter-fork PRs they create

@eecavanna eecavanna changed the title GitHub Actions test_pages_build.yaml workflow sometimes fails GitHub Actions test_pages_build.yaml workflow fails on cross-fork PRs Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants