Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Power Board Rev 6 #724

Merged
merged 4 commits into from
Jun 18, 2024
Merged

Support for Power Board Rev 6 #724

merged 4 commits into from
Jun 18, 2024

Conversation

Lohrer
Copy link
Collaborator

@Lohrer Lohrer commented May 16, 2024

What does this change intend to accomplish?

Complete #723

Checklist

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you tested your changes and ensured they work?
  • Have you updated preamp_i2c_regs.md?
  • Gave you updated the fw/preamp/CHANGELOG?

@Lohrer Lohrer added the firmware Changes to the STM32 micro on the Preamp Board label May 16, 2024
@Lohrer Lohrer self-assigned this May 16, 2024
@Lohrer Lohrer linked an issue May 16, 2024 that may be closed by this pull request
@Lohrer Lohrer force-pushed the preamp9 branch 3 times, most recently from 5fd4095 to 1c6bbdb Compare June 3, 2024 21:00
@Lohrer Lohrer force-pushed the preamp9 branch 4 times, most recently from 3c56b86 to ab5c183 Compare June 14, 2024 13:47
@Lohrer Lohrer marked this pull request as ready for review June 14, 2024 13:47
@Lohrer Lohrer requested a review from linknum23 June 14, 2024 13:47
.vscode/settings.json Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jun 14, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 4 lines in your changes missing coverage. Please review.

Project coverage is 49.52%. Comparing base (b516bb7) to head (dd36fca).
Report is 62 commits behind head on main.

Current head dd36fca differs from pull request most recent head 7d1ffc6

Please upload reports for the commit 7d1ffc6 to get more accurate results.

Files Patch % Lines
amplipi/rt.py 71.42% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #724      +/-   ##
==========================================
- Coverage   50.90%   49.52%   -1.38%     
==========================================
  Files          25       26       +1     
  Lines        5838     6366     +528     
==========================================
+ Hits         2972     3153     +181     
- Misses       2866     3213     +347     
Flag Coverage Δ
unittests 49.52% <71.42%> (-1.38%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lohrer
Copy link
Collaborator Author

Lohrer commented Jun 14, 2024

Gonna have to make some changes here, PG_9V is inconsistent depending on the hardware setup. The hardware revision with Power Board 3.B is reporting a bad PG_9V, which makes sense since that signal doesn't exist and the current firmware implementation assumes all older hardware has that signal.

@Lohrer Lohrer force-pushed the preamp9 branch 2 times, most recently from dd36fca to 7d1ffc6 Compare June 14, 2024 19:28
@Lohrer
Copy link
Collaborator Author

Lohrer commented Jun 14, 2024

This appears to work on amplipi256 (preamp v4, power v6), amplipi197 (preamp v3, power v4), and lamplipi (preamp v3, power v3). I still need to test on the original units (preamp v2 and power v2) and the intermediate combo of preamp v4 and power v4.

@Lohrer Lohrer requested a review from linknum23 June 14, 2024 19:50
@Lohrer Lohrer merged commit de87dba into main Jun 18, 2024
3 checks passed
@Lohrer Lohrer deleted the preamp9 branch June 18, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
firmware Changes to the STM32 micro on the Preamp Board
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Power Board Rev 6
3 participants