Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist visualizations param settings #5

Open
michaelbromley opened this issue Jul 31, 2016 · 1 comment
Open

Persist visualizations param settings #5

michaelbromley opened this issue Jul 31, 2016 · 1 comment

Comments

@michaelbromley
Copy link
Owner

When changing settings, the changes should be locally persisted so that when reloading the visualization, the defaults are not automatically loaded.

This also implies there should be some kind of "reset" method, to put all the params back to the default.

The design of this feature should be planned in conjunction with the "presets" feature, since they share many of the same requirements.

@michaelbromley
Copy link
Owner Author

Idea: we can assign a unique ID to any visualization by creating a hash of the name + strigified params object. This ensures that presets will be compatible with the exposed params. If the params change, the ID will change too, so any presets assigned to that ID will no longer be valid for the visualization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant