Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable authentication for /metrics by default if authentication is enabled #1342

Open
a-gerhard opened this issue Dec 8, 2023 · 1 comment
Labels

Comments

@a-gerhard
Copy link

Describe the bug
It looks like authentication for the metrics endpoint has been disabled by #1129.

I am pretty sure that these metrics can allow an external party to gather some information on what is going on in a system, as it can leak information that developers may not have thought to ever be available to the outside, like the task names.

When basic authentication is enabled, this endpoint should also require authentication by default, as many users will either not use the metrics endpoint at all, or will be able to configure a scraper to use these credentials.

Alternatively, at least allow to enable authentication here as well. For me, this renders the built-in authentication completely useless and I will need to set it up in my reverse proxy instead.

To Reproduce
Steps to reproduce the behavior:

  1. Set up Basic Authentication for flower
  2. Access the /metrics endpoint without authentication

Expected behavior
By default, the metrics endpoint requires authentication.

@a-gerhard a-gerhard added the bug label Dec 8, 2023
@a-gerhard
Copy link
Author

I'd also like to add that even though the list of unauthenticated endpoints is at the top of the documentation page, many people will skip the introduction and go straight through their preferred authentication method, and not realising that the metrics won't be protected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant