Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restangularizeElement sets parentResource when first argument is null #871

Open
aaronpeterson opened this issue Sep 11, 2014 · 0 comments · May be fixed by #993
Open

restangularizeElement sets parentResource when first argument is null #871

aaronpeterson opened this issue Sep 11, 2014 · 0 comments · May be fixed by #993

Comments

@aaronpeterson
Copy link

It appears that restangularizeElement() is erroneously setting the parentResource to the new record created that is returned by my service in the then() callback argument. On POST "creation" of a resource at my endpoint, my service returns a fully hydrated json record of the object. However, even though this restangularized Element was created with "null" as the first argument (no parent resource), further examination reveals that the object passed to the then() callback erroneously has parentResource set as well as a nulled "route" property. This was unexpected, however I have not yet reviewed the Restangular source in this area.

I love Restangular and it's been a blast to work with. Awesome work and my compliments to the contributors. I hope to contribute in the near future.

miiihi pushed a commit to miiihi/restangular that referenced this issue Nov 26, 2014
@miiihi miiihi linked a pull request Jan 6, 2015 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant