New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should Meteor.loginWithPassword have a promised-based alternative? #13068
Comments
I don't remember on which version it was added, but Meteor have the But agree, probably all methods that uses callback should have a promise alternative - which internally would just wrap the method with the |
@StorytellerCZ Maybe mark it good first issue? |
I know that Meteor.promisify is only available in Meteor v3 versions. Its docs are here btw |
With the move to
async / await
, I think mostly everything involving Accounts has a promise-based alternative with the*Async
suffix, e.g.Accounts.createUserAsync
. I noticed thatMeteor.loginWithPassword
is still callback-based only. Should it have a promise-based alternative?IMO, it seems like it should since I imagine going forward people will be more comfortable writing all their Meteor code in a promise-based style. I suppose the workaround is making everyone write their own wrapper to promisify it which seems not great.
If y'all agree, there might be other methods that also should get a promise-based alternative. I didn't look at them all. I just happened to notice this one while porting a project to 3.0.
The text was updated successfully, but these errors were encountered: