-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: 0.3.2 feature cleanup is a breaking change #1159
Labels
Comments
+1. Making changes to how features work is almost always a breaking change, therefore they should be versioned as a breaking change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Which package is this bug report for?
mpl_utils
Which Type of Package is this bug report for?
Rust library
Issue description
The f957f2d commit , which was deployed with mpl_utils 0.3.2 , introduces a breaking change because the
token
feature is no longer activated by default.This breaks using mpl_token_metadata as a dependency, and requires manually reverting mpl_utils to 0.3.1 to compile:
mpl_token_metadata
depends onmpl_utils
without specifying thetoken
feature, but uses it here.My personal recommendation is to publish a 0.3.3 version with the
token
feature still as default, and postpone clearing this default until a 0.4.x.Relevant log output
No response
Priority this issue should have
High (immediate attention needed)
The text was updated successfully, but these errors were encountered: