Remove unusued code paths for automagic filtering #42098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All the way from 2018!
|
tsmacdonald
commented
May 1, 2024
| "Add up to `max-filters` filters to dashboard `dashboard`. Takes an optional | ||
| argument `dimensions` which is a list of fields for which to create filters, else | ||
| it tries to infer by which fields it would be useful to filter." | ||
| ([dashboard max-filters] |
There was a problem hiding this comment.
The most significant change is deleting this arity and the now-unused candidates-for-filtering above.
qnkhuat
approved these changes
May 7, 2024
|
@tsmacdonald Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone? |
crisptrutski
reviewed
May 9, 2024
| (sort-by interestingness >) | ||
| (sort-by :interestingness >) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the way from 2018!
Set out to fix a typo, realized the entire branch wasn't used. That fn is only used in automagic-dashboards.populate, which uses the 3-arity version.
[Fixes #42099]