Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 [Bug]: Exchange Positions sends Position message with precision_bits set to 0 #5568

Open
1 of 2 tasks
oherrala opened this issue Nov 26, 2024 · 2 comments
Open
1 of 2 tasks
Labels
bug Something isn't working

Comments

@oherrala
Copy link

Firmware Version

2.5.12

What did you do?

Go to Nodes list, select node, scroll down and press "Exchange Positions" button.

I monitor what my node sends via separate node sending traffic into MQTT server.

Expected Behavior

When pressing exchange position button I'd expect it to send position report into channel with precision that is set in channel settings. At least it should not send it with precision_bits set to 0 since it is documented as "A value of 0 means that location data is never sent over the given channel."1

Current Behavior

Currently exchange position button sends the precise GPS location with precision_bits set to 0. This was surprising because it doesn't obey the channel settings of precision.

Participation

  • I am willing to submit a pull request for this issue.

Additional comments

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct

Footnotes

  1. https://meshtastic.org/docs/configuration/radio/channels/#position-precision

@oherrala oherrala added the bug Something isn't working label Nov 26, 2024
@garthvh
Copy link
Member

garthvh commented Dec 14, 2024

The firmware handles the precision value set by packets that use the phone gps

@garthvh garthvh transferred this issue from meshtastic/Meshtastic-Apple Dec 14, 2024
@GUVWAF
Copy link
Member

GUVWAF commented Dec 14, 2024

The firmware doesn't do this for direct messages, as we discussed in #3752.

For direct messages in >2.5 it's also not really defined, as there's no "channel" settings for this position. Nevermind, POSITION_APP packets do not use PKI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants