Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] migrate the e2e testing workflow to use playwright . #10988

Open
aabidsofi19 opened this issue May 17, 2024 · 5 comments · May be fixed by #11095
Open

[CI] migrate the e2e testing workflow to use playwright . #10988

aabidsofi19 opened this issue May 17, 2024 · 5 comments · May be fixed by #11095
Labels
area/ci Continuous Integration area/tests Testing / quality assurance framework/playwright help wanted Extra attention is needed issue/willfix This issue will be worked on

Comments

@aabidsofi19
Copy link
Contributor

Current Behavior

Migrate the meshery ui end to end testing workflow ( currently disabled ) to use the new playwright tests .
the playwright test suite can be started using make commands .

Desired Behavior

Implementation

Acceptance Tests


Contributor Guides and Handbook

@aabidsofi19 aabidsofi19 added the area/ci Continuous Integration label May 17, 2024
@leecalcote leecalcote added help wanted Extra attention is needed area/tests Testing / quality assurance framework/playwright labels May 18, 2024
@DevRish
Copy link

DevRish commented May 18, 2024

Hi @aabidsofi19 @leecalcote . I would like to work on this issue. It would be my first time contributing here, so I appreciate some guidance.

I found the existing workflow at

, found the playwright tests at https://github.com/meshery/meshery/tree/master/ui/tests/e2e and found the test-setup-ui and test-ui goals in the Makefile that run the commands to run the e2e tests.

So, I'm thinking of replacing the cypress test steps with a step that runs make test-setup-ui and make test-ui, which run the playwright tests. Is this the correct approach?

@aabidsofi19
Copy link
Contributor Author

@DevRish yeah thats the right approach .

@jameshorton2337
Copy link
Contributor

@DevRish, looks like we've had a misfire on the first PR. Try again and come back quickly or let us know if you're in need of being reassigned, so that another contributor can carry this forward.

@leecalcote
Copy link
Member

@DevRish you're encouraged to try again. In the meantime, as you work on it, I'll open this up for other contributors to undertake the crux of this issue, which is the conversion from one tool to the next.

@leecalcote leecalcote added the issue/willfix This issue will be worked on label May 25, 2024
@DevRish DevRish linked a pull request Jun 2, 2024 that will close this issue
1 task
@DevRish
Copy link

DevRish commented Jun 2, 2024

Here is my second try at this issue. Summary of changes:

  • Migrated all cypress tests except commented out ones (service_mesh_configuration_management_spec.js and configuration_filters_spec.js) to playwright. Verified passing on my system.
  • Used provider None for running the tests, because the Meshery provider was giving some errors in my local instance, which I haven't been able to fix yet. However, I think the flow of the existing tests are same irrespective of provider chosen.
  • The test for visibility of Service Mesh section in indexui.spec.js is commented out because it was failing on my end, as no such section was indeed visible in the left navigation panel on the local instance.
  • The checks to compare response bodies of requests to /api/system/adapters and /api/system/adapter/manage in settings.spec.js was done in the cypress tests, but I have excluded them because I think the request body will differ depending on which adapters the user has active and running, based on the responses I observed.

Please review @leecalcote @jameshorton2337

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci Continuous Integration area/tests Testing / quality assurance framework/playwright help wanted Extra attention is needed issue/willfix This issue will be worked on
Projects
None yet
4 participants