Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace the repetitive logic for extracting page, pagesize, search, offset from API handlers to use getPaginationParams in utils.go. #10825

Open
MUzairS15 opened this issue Apr 30, 2024 · 7 comments · May be fixed by #10962
Open

Replace the repetitive logic for extracting page, pagesize, search, offset from API handlers to use getPaginationParams in utils.go. #10825

MUzairS15 opened this issue Apr 30, 2024 · 7 comments · May be fixed by #10962
Assignees
@RyanCarlisle
Labels
component/server good first issue Good for newcomers

Comments

@MUzairS15
Copy link
Contributor 

          Replace the repetitive logic for extracting `page, pagesize, search, offset` from API handlers to use  `getPaginationParams ` in `utils.go`.

Originally posted by @MUzairS15 in #10824 (comment)
@welcome Welcome
Copy link

welcome bot commented Apr 30, 2024

Thanks for opening this issue. A contributor will be by to give feedback soon. In the meantime, please review the Contributors' Welcome Guide, engage in the discussion forum, and be sure to join the community Slack.

@RyanCarlisle
Copy link

Hi, I would like to work on this issue. Could you please assign it to me?

@MUzairS15
Copy link
Contributor Author

Thanks for volunteering @RyanCarlisle , have you successfully setup Meshery at your local environment?

@RyanCarlisle
Copy link

RyanCarlisle commented May 2, 2024 •
edited

Hi @MUzairS15, I have cloned the repo and was going through the backend code and identified all of the handlers that would require the above changes. However, I have yet to get the application up and running in my local successfully. I'll try it for a bit otherwise, would ask fellow members in Slack for help.

@nikzayn
Copy link

nikzayn commented May 5, 2024

@RyanCarlisle, I have something in mind too. If you're working on this, do let me know. Thanks!!

cc: @MUzairS15

@RyanCarlisle
Copy link

Hi @nikzayn , I shall be working on this

@nikzayn
Copy link

nikzayn commented May 5, 2024

Hi @nikzayn , I shall be working on this

That’s why I asked first buddy.

@RyanCarlisle RyanCarlisle linked a pull request May 15, 2024 that will close this issue
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RyanCarlisle RyanCarlisle

Labels
component/server good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Get pagination params in handlers from utils RyanCarlisle/meshery
3 participants
@RyanCarlisle @nikzayn @MUzairS15