Initial implementation #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t specs are not created when second stream format arrives
varsill
force-pushed
the
initial_implementation
branch
from
6fad25f to
d013850
Compare
FelonEkonom
requested changes
Nov 21, 2024
lib/transcoder/audio.ex
Outdated
| @@ -34,7 +48,11 @@ defmodule Boombox.Transcoder.Audio do | |||
| end | |||
|
|
|||
| defp do_plug_audio_transcoding(builder, %RemoteStream{content_format: Opus}, %Opus{}) do | |||
| builder |> child(:opus_parser, Opus.Parser) | |||
| builder | |||
There was a problem hiding this comment.
You cannot remove plugging Opus.Parser, the output stream format will remain %RemoteStream{content_format: Opus} but it should be %Opus{}
lib/transcoder/audio.ex
Outdated
| end | ||
|
|
||
| defp do_plug_audio_transcoding(builder, %RemoteStream{content_format: AAC}, %AAC{}) do | ||
| builder |
There was a problem hiding this comment.
We need a parser here, to change stream format from RemoteStream to %AAC{}
FelonEkonom
requested changes
Nov 27, 2024
FelonEkonom
approved these changes
Dec 9, 2024
test/integration_test.exs
Outdated
| @test_cases @video_cases ++ @audio_cases | ||
|
|
||
| Enum.map(@test_cases, fn test_case -> | ||
| test "if #{inspect(test_case.input_format)} stream is transcoded to #{inspect(test_case.output_format)}" do |
There was a problem hiding this comment.
This test should have a different name if the input format is the same as the output format, because the stream is not transcoded in such a scenario
Co-authored-by: Feliks Pobiedziński <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: