Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong colors when inside a terminal multiplexer (tmux) #39

Open
flvcst opened this issue Nov 1, 2019 · 3 comments
Open

Wrong colors when inside a terminal multiplexer (tmux) #39

flvcst opened this issue Nov 1, 2019 · 3 comments

Comments

@flvcst
Copy link

flvcst commented Nov 1, 2019

Whenever I open bitwise inside tmux my default colors are swapped to black foreground on white background. I do believe that's because some color resetting[1] happening after we call start_colors(). I've found two solutions:

  1. calling use_default_colors() after start_color() in src/misc.c
  2. calling init_pair(0, COLOR_WHITE, COLOR_BLACK) in src/interactive.c

I think 1) is the right way to deal with this problem because it will respect whatever colorscheme is being used. It's trivial to change, should I make a pull request?

[1] curs_color(3X) says that It restores the colors on the terminal to the values they had when the terminal was just turned on.

@mellowcandle
Copy link
Owner

It used to have use_default_colors() but I removed it because people complained.
see here.
a30acc9

@mellowcandle
Copy link
Owner

I don't recall what was the initial problem. I will test it in a side branch and rethink it for next release.

@mellowcandle
Copy link
Owner

Thanks for raising the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants