Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port "Language" section from reasonml.github.io #173

Open
jchavarri opened this issue Apr 8, 2024 · 2 comments
Open

Port "Language" section from reasonml.github.io #173

jchavarri opened this issue Apr 8, 2024 · 2 comments

Comments

@jchavarri
Copy link
Member

Everything that is under "Language Basics" should be a section in melange.re, so we can link to it from the melange book, etc.

https://reasonml.github.io/docs/en/overview

image
@davesnx
Copy link
Member

davesnx commented Oct 11, 2024

I don't think adding "Language" is beneficial for melange. Since Melange is mainly a compiler that supports more than 1 language. Explaining Reason or explaining OCaml will make the concept of "being a compiler" less clear.

I would prefer if we have a Syntax section where we explain this (#38)

@feihong
Copy link
Collaborator

feihong commented Oct 11, 2024

So, I looked back at the original PR that gave birth to this issue, and I found this comment:

But on second thought, I have hesitation about it, because features like record spreading are only available in Reason syntax. 🤔

But while writing the book, I was constantly looking at the Melange and Reason docs, and speaking from my perspective as a user, I kinda wished that I didn't have to jump between them. Also, as I went further in the book, I realized there was no way to avoid talking about OCaml syntax, since error messages use them and much of the core language reference pages (that I sometimes link to) uses them too. But if Language Basics section is to cover both Reason and OCaml syntax, then it needs to be on Melange docs site, right?

I don't know if these are good enough reasons to go through with porting Language Basics section, but I think we all agree we should have a Syntax page, so I'll create a separate PR for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants