Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add guideline for being explicit when defining types in externals #142

Open
jchavarri opened this issue Nov 5, 2023 · 0 comments
Open

Comments

@jchavarri
Copy link
Member

Externals should list all the params of the function, and type aliases should be avoided:

external foo : int -> unit = "foo"

let () = foo 2 (* foo(2); *)

type t = int -> unit

external bar : t = "bar"

let () = bar 2 (* Curry._1(bar, 2); *)

The docs should list this guideline somehow, somewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant