Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failure handling in spec retry #184

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

kpdecker
Copy link

When running in retry mode with a failing snapshot, we would see the expected failure on the first attempt. On the second attempt this would pass as the numeric ID for the snapshot was incremented, creating a new snapshot.

This PR changes behavior so that

  • Snapshots are not written if autopassNewSnapshots is false
  • Snapshot id trackers are reset after test completion

kpdecker added 3 commits June 16, 2021 12:12
This prevents new number suffixes being allocated for given snapshots in the event of a rety.
@kpdecker kpdecker changed the title Fix failure handling in retry Fix failure handling in spec retry Jun 16, 2021
window:before:unload reset would break tests that have explicit reloads in them
@edimitchel
Copy link

Nice trick ! I did think about resetting after test completion !

@ollybondareva
Copy link

@edimitchel what about merging this pr?

@edimitchel
Copy link

I cannot, build is not passing and I cannot change anything on project for be able to do...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants