-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for language settings and search parameter #620
Open
necocen
wants to merge
3
commits into
meilisearch:main
Choose a base branch
from
necocen:feature/add-support-for-language-settings
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add support for language settings and search parameter #620
necocen
wants to merge
3
commits into
meilisearch:main
from
necocen:feature/add-support-for-language-settings
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ManyTheFish
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
meili-bors bot
added a commit
that referenced
this pull request
Dec 3, 2024
620: Add support for language settings and search parameter r=ManyTheFish a=necocen # Pull Request ## Related issue Fixes #611 ## What does this PR do? - Added `locales` parameter and `with_locales` method to `SearchQuery` struct - Added localized attributes related methods to `Index` and `Settings` - Added tests - Added code samples - search_parameter_reference_locales_1 - get_localized_attribute_settings_1 - update_localized_attribute_settings_1 - reset_localized_attribute_settings_1 ## PR checklist Please check if your PR fulfills the following requirements: - [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)? - [x] Have you read the contributing guidelines? - [x] Have you made sure that the title is accurate and descriptive of the changes? Thank you so much for contributing to Meilisearch! Co-authored-by: necocen <[email protected]>
Build failed: |
bors try |
tryBuild failed: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue
Fixes #611
What does this PR do?
locales
parameter andwith_locales
method toSearchQuery
structIndex
andSettings
PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!