Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow users to customize facet value sort behaviour #514

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Allow users to customize facet value sort behaviour #514

wants to merge 3 commits into from

Conversation

hmacr
Copy link
Contributor

@hmacr hmacr commented Sep 6, 2023

Pull Request

Related issue

Fixes #502

What does this PR do?

  • Introduce FacetSortValue enum
  • Add FacetSortSetting to FacetSetting

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

Kerollmops
Kerollmops requested changes Sep 12, 2023
View reviewed changes
Copy link
Member

@Kerollmops Kerollmops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Thank you for the changes. Would it be possible to change the casing of the FacetSortValue enum variants, please?

src/settings.rs
Comment on lines +34 to +36
ALPHA,
#[serde(rename = "count")]
COUNT,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ALPHA,
#[serde(rename = "count")]
COUNT,
Alpha,
#[serde(rename = "count")]
Count,

curquiza
curquiza requested changes Sep 12, 2023
View reviewed changes
Copy link
Member

@curquiza curquiza left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @hmacr

thanks a lot for your multiple PRs

Can you rebase the branch? there are git conflicts currently

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curquiza curquiza curquiza requested changes

@Kerollmops Kerollmops Kerollmops requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[v1.3] Sort facets value by alphanumerical or count order
3 participants
@hmacr @Kerollmops @curquiza