Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group by feature not by type: device state tracker #152

Open
skulptur opened this issue Jun 23, 2020 · 1 comment
Open

Group by feature not by type: device state tracker #152

skulptur opened this issue Jun 23, 2020 · 1 comment

Comments

@skulptur
Copy link
Contributor

I think the util directory should have a subdir deviceStateTracker by default with these files:
https://github.com/mediamonks/muban/blob/master/src/app/data/shared-variable/media-queries.json
https://github.com/mediamonks/muban/blob/master/src/app/util/deviceStateTracker.ts

And then we remove data/shared-variable

@ThaNarie
Copy link
Member

The idea was to have a common place for sharing variables between JS and CSS, and document that as such. media-queries was just one of them we use by default, there could be others.

If we feel this is not used as much in practice, and can be clearly documented for when it's needed, then i'm fine with (re)moving them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants