Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal to rename the mockdata files with a reference to the block #136

Open
pigeonfresh opened this issue Apr 30, 2020 · 3 comments
Open
Labels

Comments

@pigeonfresh
Copy link
Contributor

data/c01-hero-default.yaml
data/c01-hero-*.yaml

A naming convention like this would make it easier to open data files for a specific component in editors.

@ThaNarie
Copy link
Member

Works for me :)

@pigeonfresh
Copy link
Contributor Author

For legibility I would suggest snake-case, especially since most editors have a smart enough search system to deal with different casings.

@skulptur
Copy link
Contributor

@pigeonfresh I think you meant kebab-case. PR looks good, but I don't agree with *-data.yaml. All yamls are data, and we're not doing *-template.hbs or *-styles.scss.

Can we remove that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants