Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

possible Border-image generator UI updates #96

Open
Tracked by #180
jsnkuhn opened this issue Jan 4, 2023 · 0 comments
Open
Tracked by #180

possible Border-image generator UI updates #96

jsnkuhn opened this issue Jan 4, 2023 · 0 comments
Labels
effort: large Task is large effort. enhancement Improves an existing feature. idle Issues and pull requests with no activity for three months. tool: border-image-generator

Comments

@jsnkuhn
Copy link
Contributor

jsnkuhn commented Jan 4, 2023

The recent MDN redesign has reduced the width available for the Border-image Generator. As an example there is now only room for 2 boxes dedicated to each individual property per grid line instead of the old design that had room to show 3. This makes the page a bit longer and therefore slightly harder to use. Have had some thoughts about changes to help with this:

  1. the image selection options at the top (including the UI to upload your own image) seem like they should be in a box similar to all the others titled "border-image-source". Would take up less room and have a more consistent UI. This might need to be 2 grid spots.

  2. I'm not entirely sure I understand the point of the area labeled "control box". It's marking a fixed height for the area below it but I don't think it's really necessary. Will explain more in up coming points

  3. the visual border-image-slice UI is very nice but it seems like it should just go in the "border-image-slice" titled box with the other border-image-slice controls. This might also then need to be 2 grid spots.

  4. All that would leave in the "control box" area is the current drag-able preview element (which by the way is always drag-able even if the drag-able toggle is off) with the live border-image. Maybe we just add the border-image code to each of the individual "border-image-" property boxes so that a preview of the resulting border-image is always on screen? A side benefit of this is seeing the border-image on 2 different sized elements (one gird space wide and 2 grid spaces wide).

  5. Dev tools is calling out the heading text color contrast on the individual "border-image-x" properties for not meeting the AA standard. So that should get fixed as well.

Any other thoughts on the UI?

@caugner caugner added needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. enhancement Improves an existing feature. effort: large Task is large effort. and removed needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. labels Oct 10, 2023
@github-actions github-actions bot added the idle Issues and pull requests with no activity for three months. label Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: large Task is large effort. enhancement Improves an existing feature. idle Issues and pull requests with no activity for three months. tool: border-image-generator
Projects
None yet
Development

No branches or pull requests

2 participants