Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent downloadable starting code for task #132

Open
Arvton opened this issue Apr 8, 2023 · 3 comments
Open

Inconsistent downloadable starting code for task #132

Arvton opened this issue Apr 8, 2023 · 3 comments
Labels
bug Indicates an unexpected problem or unintended behavior. effort: small Task is a small effort. good first issue A good issue for newcomers to get started with. idle Issues and pull requests with no activity for three months.

Comments

@Arvton
Copy link
Contributor

Arvton commented Apr 8, 2023

Downloadable starting code

learn/tasks/writing-modes/logical-width-height-download.html
It differs from code shown in online editor.

Online editor code

learn/tasks/writing-modes/logical-width-height.html
Should the writing-mode for the vertical class be declared inside of the editable styles area? It can be declared after the box class styles. This makes the task easier to solve too.

@caugner caugner added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Oct 10, 2023
@caugner
Copy link
Contributor

caugner commented Oct 11, 2023

I agree with the OP:

  1. In the download version, the .vertical CSS rule could be moved below the .box rule here:
    .vertical {
    writing-mode: vertical-rl;
    }
    .box {
    border: 5px solid rebeccapurple;
    background-color: lightgray;
    padding: 40px;
    margin: 40px;
    width: 200px;
    height: 100px;
    }
  2. In the editor version, the .vertical CSS rule should be moved inside the editable block:
    <style>
    .vertical {
    writing-mode: vertical-rl;
    }
    </style>
    <style class="editable">
    .box {
    border: 5px solid rebeccapurple;
    background-color: lightgray;
    padding: 40px;
    margin: 40px;
    width: 200px;
    height: 100px;
    }
    </style>

    And it also needs to be added inside the textarea:
    <textarea class="playable playable-css" style="height: 180px;">
    .box {
    border: 5px solid rebeccapurple;
    background-color: lightgray;
    padding: 40px;
    margin: 40px;
    width: 200px;
    height: 100px;
    }
    </textarea>

@caugner caugner added bug Indicates an unexpected problem or unintended behavior. good first issue A good issue for newcomers to get started with. effort: small Task is a small effort. and removed needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. labels Oct 11, 2023
@pragyamishra56
Copy link

@caugner Sir could you assign me this issue?

@github-actions github-actions bot added the idle Issues and pull requests with no activity for three months. label Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behavior. effort: small Task is a small effort. good first issue A good issue for newcomers to get started with. idle Issues and pull requests with no activity for three months.
Projects
None yet
Development

No branches or pull requests

3 participants