-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mirostat sampling crashes #14
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is because of some API changes to the "Candidates" container in
drama_llama
. the container used to have a fixed size and the sampling functions would either return slices orVec
s. When the interface became more functional, taking self by value and returning self, it broke some of the sampling methods.They're not covered, so it's unsurprising. To fix this we should generate some test data and cover the sampling functions so this can't happen again.
The text was updated successfully, but these errors were encountered: