{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":786537173,"defaultBranch":"main","name":"drama_llama","ownerLogin":"mdegans","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2024-04-14T19:00:03.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/47511965?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1718749779.0","currentOid":""},"activityList":{"items":[{"before":"10a131672403ed37fdbfd492170fbfa11634dbfd","after":"1b7e460500342b8102b57167cd28043c83bd6ac4","ref":"refs/heads/main","pushedAt":"2024-06-19T20:30:02.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"mdegans","name":"Michael de Gans","path":"/mdegans","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/47511965?s=80&v=4"},"commit":{"message":"cross platform `path_to_cstring`\n\n* Found a solution that works on all tested platforms by trying things.","shortMessageHtmlLink":"cross platform <code>path_to_cstring</code>"}},{"before":"84be2fb7aa823879195c01b55d9cd6cba685d4cc","after":"10a131672403ed37fdbfd492170fbfa11634dbfd","ref":"refs/heads/main","pushedAt":"2024-06-18T22:33:48.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"mdegans","name":"Michael de Gans","path":"/mdegans","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/47511965?s=80&v=4"},"commit":{"message":"Fix windows build. (#13)\n\nThere was some Unix-specific code breaking the build.","shortMessageHtmlLink":"Fix windows build. (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2360850237\" data-permission-text=\"Title is private\" data-url=\"https://github.com/mdegans/drama_llama/issues/13\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/mdegans/drama_llama/pull/13/hovercard\" href=\"https://github.com/mdegans/drama_llama/pull/13\">#13</a>)"}},{"before":"24bc21b74c9a6627f2af64de783b75accbf8d720","after":"84be2fb7aa823879195c01b55d9cd6cba685d4cc","ref":"refs/heads/main","pushedAt":"2024-06-18T22:32:25.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"mdegans","name":"Michael de Gans","path":"/mdegans","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/47511965?s=80&v=4"},"commit":{"message":"Fix windows build. (#13)\n\nThere was some Unix-specific code breaking the build.","shortMessageHtmlLink":"Fix windows build. (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2360850237\" data-permission-text=\"Title is private\" data-url=\"https://github.com/mdegans/drama_llama/issues/13\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/mdegans/drama_llama/pull/13/hovercard\" href=\"https://github.com/mdegans/drama_llama/pull/13\">#13</a>)"}},{"before":"5c2c80ebd2d434f14f1b8baed2d1893c631d7d7d","after":null,"ref":"refs/heads/fix_windows","pushedAt":"2024-06-18T22:29:39.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"mdegans","name":"Michael de Gans","path":"/mdegans","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/47511965?s=80&v=4"}},{"before":"af53558230e93e339d765d67905da610afc077e2","after":"24bc21b74c9a6627f2af64de783b75accbf8d720","ref":"refs/heads/main","pushedAt":"2024-06-18T22:29:36.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"mdegans","name":"Michael de Gans","path":"/mdegans","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/47511965?s=80&v=4"},"commit":{"message":"Fix windows build. (#13)\n\nThere was some Unix-specific code breaking the build.","shortMessageHtmlLink":"Fix windows build. (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2360850237\" data-permission-text=\"Title is private\" data-url=\"https://github.com/mdegans/drama_llama/issues/13\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/mdegans/drama_llama/pull/13/hovercard\" href=\"https://github.com/mdegans/drama_llama/pull/13\">#13</a>)"}},{"before":"5ee4d5102732ea6bc629451ef79cddfe448ea59a","after":"af53558230e93e339d765d67905da610afc077e2","ref":"refs/heads/main","pushedAt":"2024-06-18T22:28:18.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"mdegans","name":"Michael de Gans","path":"/mdegans","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/47511965?s=80&v=4"},"commit":{"message":"add `max_context_size` to `PredictOptions::draw`\n\nThis is technically breaking so we're incrementing the minor version.","shortMessageHtmlLink":"add <code>max_context_size</code> to <code>PredictOptions::draw</code>"}},{"before":null,"after":"5c2c80ebd2d434f14f1b8baed2d1893c631d7d7d","ref":"refs/heads/fix_windows","pushedAt":"2024-06-18T22:28:01.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"mdegans","name":"Michael de Gans","path":"/mdegans","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/47511965?s=80&v=4"},"commit":{"message":"Fix windows build.\n\nThere was some Unix-specific code breaking the build.","shortMessageHtmlLink":"Fix windows build."}},{"before":"b6095610d5d1b127a5c0350b009249575e1922a9","after":"5ee4d5102732ea6bc629451ef79cddfe448ea59a","ref":"refs/heads/main","pushedAt":"2024-06-18T19:25:00.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"mdegans","name":"Michael de Gans","path":"/mdegans","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/47511965?s=80&v=4"},"commit":{"message":"increment patch version","shortMessageHtmlLink":"increment patch version"}},{"before":"af53558230e93e339d765d67905da610afc077e2","after":"b6095610d5d1b127a5c0350b009249575e1922a9","ref":"refs/heads/main","pushedAt":"2024-06-18T19:23:30.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"mdegans","name":"Michael de Gans","path":"/mdegans","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/47511965?s=80&v=4"},"commit":{"message":"remove `Cargo.lock`\n\nThis is primarily a library project so It's best not to commit it.","shortMessageHtmlLink":"remove <code>Cargo.lock</code>"}},{"before":"34f2e85b929528c86af1b464f18b17e26b5e9eff","after":"af53558230e93e339d765d67905da610afc077e2","ref":"refs/heads/main","pushedAt":"2024-06-14T23:19:03.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"mdegans","name":"Michael de Gans","path":"/mdegans","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/47511965?s=80&v=4"},"commit":{"message":"add `max_context_size` to `PredictOptions::draw`\n\nThis is technically breaking so we're incrementing the minor version.","shortMessageHtmlLink":"add <code>max_context_size</code> to <code>PredictOptions::draw</code>"}},{"before":"ea8520f3861418b2224544d59583e709e77fcc4d","after":"34f2e85b929528c86af1b464f18b17e26b5e9eff","ref":"refs/heads/main","pushedAt":"2024-06-14T23:11:52.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"mdegans","name":"Michael de Gans","path":"/mdegans","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/47511965?s=80&v=4"},"commit":{"message":"fix `Model::meta` and `Model::desc`\n\nThe returned strings included a null character. That is now truncated.","shortMessageHtmlLink":"fix <code>Model::meta</code> and <code>Model::desc</code>"}},{"before":"f9f92d02484c0471cc6c498a80e566af7cb2f529","after":"ea8520f3861418b2224544d59583e709e77fcc4d","ref":"refs/heads/main","pushedAt":"2024-06-14T05:24:21.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"mdegans","name":"Michael de Gans","path":"/mdegans","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/47511965?s=80&v=4"},"commit":{"message":"make `engine::NewError` public\n\nOtherwise it makes handling errors difficult. It was always mean to be public.","shortMessageHtmlLink":"make <code>engine::NewError</code> public"}},{"before":"88b17413ff9f390021f280d605cd66f975fc1b74","after":"f9f92d02484c0471cc6c498a80e566af7cb2f529","ref":"refs/heads/main","pushedAt":"2024-05-26T04:23:23.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"mdegans","name":"Michael de Gans","path":"/mdegans","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/47511965?s=80&v=4"},"commit":{"message":"Fix stop criteria\n\nThe previous fix didn't take into account the reason for the original logic, which was that stop criteria could be in the middle of a token.\n\nThis reverts that change while fixing the character boundary issue by decrementing the end index until it's at a character boundary.","shortMessageHtmlLink":"Fix stop criteria"}},{"before":"907a1779966b443fa28e55f2d108ce02edbe7aeb","after":"88b17413ff9f390021f280d605cd66f975fc1b74","ref":"refs/heads/main","pushedAt":"2024-05-26T04:05:58.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"mdegans","name":"Michael de Gans","path":"/mdegans","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/47511965?s=80&v=4"},"commit":{"message":"Crash fix\n* It was possible that an index into a string could be in between characters, causing a crash. The new code is much simpler and it shouldn't be possible anymore.","shortMessageHtmlLink":"Crash fix"}},{"before":"704831244f67af5023529f49b515917734a3bce6","after":"907a1779966b443fa28e55f2d108ce02edbe7aeb","ref":"refs/heads/main","pushedAt":"2024-05-26T03:28:22.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"mdegans","name":"Michael de Gans","path":"/mdegans","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/47511965?s=80&v=4"},"commit":{"message":"Patch: fix `NGram` removal in gui `RepetitionOptions`\n\n* This fixes the remove button not removing NGrams","shortMessageHtmlLink":"Patch: fix <code>NGram</code> removal in gui <code>RepetitionOptions</code>"}},{"before":"3c4d4ce3afd2327a4c20b657118409cb3bfd2f95","after":null,"ref":"refs/heads/egui","pushedAt":"2024-05-26T03:16:05.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"mdegans","name":"Michael de Gans","path":"/mdegans","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/47511965?s=80&v=4"}},{"before":"8ebaa5dd7af1a07980dc1ffe0520418be5347945","after":"704831244f67af5023529f49b515917734a3bce6","ref":"refs/heads/main","pushedAt":"2024-05-26T03:15:36.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"mdegans","name":"Michael de Gans","path":"/mdegans","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/47511965?s=80&v=4"},"commit":{"message":"`egui` ui features for settings (#12)\n\nThis commit adds `egui` support for `PredictOptions` and children. It's breaking since it makes some very minor changes to sampling functions on `Candidates`.\n\nA `settings_tool` binary has also been added to test the gui. The purpose of this change is mostly for the `weave` project.\n\n* Increment the minor version.\n* `egui` `draw` and `draw_inner` methods for `PredictOptions` and children such as:\n  - `SampleOptions`\n  - `SamplingMode`\n  - `RepetitionOptions`","shortMessageHtmlLink":"<code>egui</code> ui features for settings (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2317411361\" data-permission-text=\"Title is private\" data-url=\"https://github.com/mdegans/drama_llama/issues/12\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/mdegans/drama_llama/pull/12/hovercard\" href=\"https://github.com/mdegans/drama_llama/pull/12\">#12</a>)"}},{"before":null,"after":"3c4d4ce3afd2327a4c20b657118409cb3bfd2f95","ref":"refs/heads/egui","pushedAt":"2024-05-26T03:14:58.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"mdegans","name":"Michael de Gans","path":"/mdegans","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/47511965?s=80&v=4"},"commit":{"message":"`egui` ui features for settings\n\nThis commit adds `egui` support for `PredictOptions` and children. It's breaking since it makes some very minor changes to sampling functions on `Candidates`.\n\nA `settings_tool` binary has also been added to test the gui. The purpose of this change is mostly for the `weave` project.\n\n* Increment the minor version.\n* `egui` `draw` and `draw_inner` methods for `PredictOptions` and children such as:\n  - `SampleOptions`\n  - `SamplingMode`\n  - `RepetitionOptions`","shortMessageHtmlLink":"<code>egui</code> ui features for settings"}},{"before":"dc942acd584a2577ac23c16cdedcdb15c58fdad2","after":"8ebaa5dd7af1a07980dc1ffe0520418be5347945","ref":"refs/heads/main","pushedAt":"2024-05-24T18:55:29.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"mdegans","name":"Michael de Gans","path":"/mdegans","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/47511965?s=80&v=4"},"commit":{"message":"Crash fix\n- in `locally_typical`\n\nHopefully a panic is impossible now when we unwrap just below.","shortMessageHtmlLink":"Crash fix"}},{"before":"5565a763ea5e9dac27baa03ec33a3ac42de123a8","after":"dc942acd584a2577ac23c16cdedcdb15c58fdad2","ref":"refs/heads/main","pushedAt":"2024-05-24T18:50:00.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"mdegans","name":"Michael de Gans","path":"/mdegans","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/47511965?s=80&v=4"},"commit":{"message":"FIX: crash in `locally_typical` sampling\n\nWe didn't check of a probability was zero before we called `ln()` resulting in a NaN which caused the sort to return None causing a panic on unwrap.","shortMessageHtmlLink":"FIX: crash in <code>locally_typical</code> sampling"}},{"before":"e8f77e0dd68c6bd3cc724b090a61d95827113705","after":"5565a763ea5e9dac27baa03ec33a3ac42de123a8","ref":"refs/heads/main","pushedAt":"2024-05-24T06:28:38.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"mdegans","name":"Michael de Gans","path":"/mdegans","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/47511965?s=80&v=4"},"commit":{"message":"hotfix: bindings update\n\nminor change to use of `llama_token_to_piece`","shortMessageHtmlLink":"hotfix: bindings update"}},{"before":"74db8dc68fbec45aeb59cc73700531eb0643cbae","after":"e8f77e0dd68c6bd3cc724b090a61d95827113705","ref":"refs/heads/main","pushedAt":"2024-05-24T06:25:29.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"mdegans","name":"Michael de Gans","path":"/mdegans","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/47511965?s=80&v=4"},"commit":{"message":"update `llama.cpp`\n\nThe candidate crash was not in fact caused by bad data from the kernel or ids out of range, rather my fault. So nothing to do with this issue here:\n\nhttps://github.com/ggerganov/llama.cpp/issues/7476\n\nThe `Candidates` container can shrink, but it's only used in locally typical sampling, and I forgot it did that which is why ids are out of range in that case. I could use a HashMap to solve i or an associative array, but it's easier just to remove the duplicate check from `Candidates::from_vec`.\n\nI missed it because I checked all uses of `from_vec`, not the actual call stack, and this use in locally typical calls `from_iter` which calls `from_vec` with  truncated `Candidates`, causing the crash.\n\n```rust\n        indices\n            .iter()\n            .take(new_len)\n            .map(|&index| new.data[index])\n            .collect()\n```\n\nThe model will now have to be updated, but whatever.","shortMessageHtmlLink":"update <code>llama.cpp</code>"}},{"before":"f3282f58a44a116ba61fd9cedd6095210d7575c9","after":"74db8dc68fbec45aeb59cc73700531eb0643cbae","ref":"refs/heads/main","pushedAt":"2024-05-23T23:51:28.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"mdegans","name":"Michael de Gans","path":"/mdegans","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/47511965?s=80&v=4"},"commit":{"message":"Reverting `llama.cpp` upgrade\n\nIt appears recent changes broke the tokenizer. Tokens ids are now **out of the vocabulary range** causing a crash here:\n\n```rust         *id_seen.get_mut(data[0].id as usize).unwrap() = true;\n```\n\nin `Candidates::from_vec`\n\nIt may also be possible that `llama_get_logits_ith` changed somehow and is returning garbage. Either is **terrible** very bad no good news.\n\nIf we didn't check for this we would be indexing into garbage data. Until this is fixed we're reverting to a previous version that also doesn't require us to rebuild or convert our models yet another time :/\n\nRelated:\nhttps://github.com/ggerganov/llama.cpp/issues/7476","shortMessageHtmlLink":"Reverting <code>llama.cpp</code> upgrade"}},{"before":"a5c4aca59ae0c15c7f20e0aff88fae82f0b39d84","after":"f3282f58a44a116ba61fd9cedd6095210d7575c9","ref":"refs/heads/main","pushedAt":"2024-05-23T23:14:57.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"mdegans","name":"Michael de Gans","path":"/mdegans","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/47511965?s=80&v=4"},"commit":{"message":"Patch fixes\n\n- Before default sampling options was greedy. This was a mistake. Now the default is locally typical sampling with a relatively minor repetition penalty. This may be adjusted.\n- Minor fix to tokenization where BOS was still not added.\n- Update dependencies","shortMessageHtmlLink":"Patch fixes"}},{"before":"87d0a5f408ab39e4d0c27bc29c7b0f3c410d7746","after":null,"ref":"refs/heads/fixes","pushedAt":"2024-05-21T00:39:10.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"mdegans","name":"Michael de Gans","path":"/mdegans","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/47511965?s=80&v=4"}},{"before":"7143574ac8558bf9134cffa3d8c015d911195205","after":"a5c4aca59ae0c15c7f20e0aff88fae82f0b39d84","ref":"refs/heads/main","pushedAt":"2024-05-21T00:39:07.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"mdegans","name":"Michael de Gans","path":"/mdegans","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/47511965?s=80&v=4"},"commit":{"message":"Fixes (#11)\n\n* fix utf-8 related crashes\r\n\r\nIt is possible for the model to return non-utf-8 characters, so we substitute such characters rather than unwrap.\r\n\r\n* Increment patch version\r\n\r\n* Change BOS default\r\n\r\nChange `Model::DEFAULT_ADD_BOS` to `true`\r\n\r\nIf the model does not specify (like some conversions of LLaMA 3) BOS is prepended.","shortMessageHtmlLink":"Fixes (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2307032214\" data-permission-text=\"Title is private\" data-url=\"https://github.com/mdegans/drama_llama/issues/11\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/mdegans/drama_llama/pull/11/hovercard\" href=\"https://github.com/mdegans/drama_llama/pull/11\">#11</a>)"}},{"before":null,"after":"87d0a5f408ab39e4d0c27bc29c7b0f3c410d7746","ref":"refs/heads/fixes","pushedAt":"2024-05-21T00:35:56.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"mdegans","name":"Michael de Gans","path":"/mdegans","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/47511965?s=80&v=4"},"commit":{"message":"Change BOS default\n\nChange `Model::DEFAULT_ADD_BOS` to `true`\n\nIf the model does not specify (like some conversions of LLaMA 3) BOS is prepended.","shortMessageHtmlLink":"Change BOS default"}},{"before":"97d537d0dc77837b49683ea75fa8e6b957371dda","after":"7143574ac8558bf9134cffa3d8c015d911195205","ref":"refs/heads/main","pushedAt":"2024-05-13T21:59:56.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"mdegans","name":"Michael de Gans","path":"/mdegans","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/47511965?s=80&v=4"},"commit":{"message":"Fix prediction crash (#10)\n\nCaused by a logic error.","shortMessageHtmlLink":"Fix prediction crash (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2293918723\" data-permission-text=\"Title is private\" data-url=\"https://github.com/mdegans/drama_llama/issues/10\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/mdegans/drama_llama/pull/10/hovercard\" href=\"https://github.com/mdegans/drama_llama/pull/10\">#10</a>)"}},{"before":null,"after":"915c498e74239e27c06760a9595f25a274dd92f4","ref":"refs/heads/fix_token_predictor_crash","pushedAt":"2024-05-13T21:59:32.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"mdegans","name":"Michael de Gans","path":"/mdegans","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/47511965?s=80&v=4"},"commit":{"message":"Fix prediction crash\n\nCaused by a logic error.","shortMessageHtmlLink":"Fix prediction crash"}},{"before":"68a80af5d392fad26ea5d6d235520fbdb2c73e17","after":null,"ref":"refs/heads/dev","pushedAt":"2024-05-13T19:27:53.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"mdegans","name":"Michael de Gans","path":"/mdegans","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/47511965?s=80&v=4"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEaemEMAA","startCursor":null,"endCursor":null}},"title":"Activity · mdegans/drama_llama"}