Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapse - Content resizing within a Collapse-Component #172

Open
iprzybysz opened this issue May 21, 2024 Discussed in #171 · 1 comment
Open

Collapse - Content resizing within a Collapse-Component #172

iprzybysz opened this issue May 21, 2024 Discussed in #171 · 1 comment
Milestone

Comments

@iprzybysz
Copy link
Contributor

Discussed in #171

Originally posted by SergejGleithmann May 19, 2024
Hello, I observed, that the Collapse-Component makes use of style attributes instead of using Tailwind classes for showing and hiding the Collapse-Component. Maybe I am missing the point, but imo this is bad, because the height is set to an absolute px value and therefore does not adjust if content within the collapse comonent changes size. I think it would be better, if the height is not set via the style tag or at least omit the positiv height in case of an opened Collape-Component.

@iprzybysz iprzybysz added this to the v1.0.0-alpha3 milestone May 21, 2024
@SergejGleithmann
Copy link

Hello, I think I might have a solution: The Collapse Element handles the resize event correctly. Now as far as I can tell it would be sufficient to trigger the handleResize function, when the children of the element are changing. I am not familliar with TypeScript, so I feel unqualified to implement this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants