Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deduping is not working when stale #164

Open
muhammedea opened this issue Nov 28, 2024 · 1 comment
Open

Deduping is not working when stale #164

muhammedea opened this issue Nov 28, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@muhammedea
Copy link

Hi. Deduplication logic work perfect when cache is empty. But when the item is stale, than if you make 10 request all of them will execute separately and parallel.
Is this intentional or am I doing the configuration wrong?
@mcollina
Copy link
Owner

Oh, you stumbled on a nice bug. Would you like to send a PR?

@mcollina mcollina added the bug Something isn't working label Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mcollina @muhammedea